doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #601] [MERGED] Add 'contains' comparison #8430

New Issue
Open
opened 2026-01-22 15:59:54 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:59:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/601
Author: @jankramer
Created: 3/5/2013
Status: ✅ Merged
Merged: 3/12/2013
Merged by: @beberlei

Base: master ← Head: add-contains-comparison

📝 Commits (2)

  • 7606233 Added 'contains' comparison
  • 9d5e7eb Added composer.lock to .gitignore

📊 Changes

6 files changed (+45 additions, -517 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 composer.json (+1 -0)
➖ composer.lock (+0 -507)
📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+10 -9)
📝 lib/Doctrine/ORM/Persisters/SqlValueVisitor.php (+17 -1)
📝 tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php (+16 -0)

📄 Description

As mentioned by @stof in doctrine/collections#5, the 'contains' comparison for matching collections should also be added to the ORM.

The first commit is only present in this PR because the doctrine/collections 1.0 release does not contain the recent addition. It should be removed/altered after a new version has been tagged, I think?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/601 **Author:** [@jankramer](https://github.com/jankramer) **Created:** 3/5/2013 **Status:** ✅ Merged **Merged:** 3/12/2013 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `add-contains-comparison` --- ### 📝 Commits (2) - [`7606233`](https://github.com/doctrine/orm/commit/760623346c9423dac76ff541d81066018ee28035) Added 'contains' comparison - [`9d5e7eb`](https://github.com/doctrine/orm/commit/9d5e7eb6e9f8f422f3d7cb46d23f1ce50b0250d7) Added composer.lock to .gitignore ### 📊 Changes **6 files changed** (+45 additions, -517 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `composer.json` (+1 -0) ➖ `composer.lock` (+0 -507) 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+10 -9) 📝 `lib/Doctrine/ORM/Persisters/SqlValueVisitor.php` (+17 -1) 📝 `tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php` (+16 -0) </details> ### 📄 Description As mentioned by @stof in doctrine/collections#5, the 'contains' comparison for matching collections should also be added to the ORM. The first commit is only present in this PR because the doctrine/collections 1.0 release does not contain the recent addition. It should be removed/altered after a new version has been tagged, I think? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:59:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?