[PR #569] [MERGED] Hotfix/pre flush event args params #8385

New Issue

admin · 2026-01-22T15:59:41+01:00

admin commented

2026-01-22 15:59:41 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/569
Author: @Ocramius
Created: 2/4/2013
Status: ✅ Merged
Merged: 2/12/2013
Merged by: @FabioBatSilva

Base: master ← Head: hotfix/pre-flush-event-args-params

📝 Commits (2)

3ebed10 Strong typehinting to avoid incorrect constructor params
f281dbb Fixing incorrect constructor params for PreFlushEventArgs

📊 Changes

4 files changed (+14 additions, -8 deletions)

View changed files

📝 lib/Doctrine/ORM/Event/OnClearEventArgs.php (+3 -1)
📝 lib/Doctrine/ORM/Event/OnFlushEventArgs.php (+2 -1)
📝 lib/Doctrine/ORM/Event/PreFlushEventArgs.php (+8 -5)
📝 lib/Doctrine/ORM/UnitOfWork.php (+1 -1)

📄 Description

As reported by a user on IRC, the PreFlushEventArgs object was built with incorrect parameters. this fix solves the problem by typehinting the constructor.

Tests aren't really necessary since a lot of functional tests were simply broken because of this additional typehint.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/569 **Author:** [@Ocramius](https://github.com/Ocramius) **Created:** 2/4/2013 **Status:** ✅ Merged **Merged:** 2/12/2013 **Merged by:** [@FabioBatSilva](https://github.com/FabioBatSilva) **Base:** `master` ← **Head:** `hotfix/pre-flush-event-args-params` --- ### 📝 Commits (2) - [`3ebed10`](https://github.com/doctrine/orm/commit/3ebed101fdc6a0aeb32e26aca9bfd7f3bd9a3caa) Strong typehinting to avoid incorrect constructor params - [`f281dbb`](https://github.com/doctrine/orm/commit/f281dbbf54fd6446c553e4d965e6242be34e6034) Fixing incorrect constructor params for PreFlushEventArgs ### 📊 Changes **4 files changed** (+14 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Event/OnClearEventArgs.php` (+3 -1) 📝 `lib/Doctrine/ORM/Event/OnFlushEventArgs.php` (+2 -1) 📝 `lib/Doctrine/ORM/Event/PreFlushEventArgs.php` (+8 -5) 📝 `lib/Doctrine/ORM/UnitOfWork.php` (+1 -1) </details> ### 📄 Description As reported by a user on IRC, the `PreFlushEventArgs` object was built with incorrect parameters. this fix solves the problem by typehinting the constructor. Tests aren't really necessary since a lot of functional tests were simply broken because of this additional typehint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:59:41 +01:00

admin closed this issue

2026-01-22 15:59:41 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8385