[PR #547] [CLOSED] Revived #265: [WIP] Mapping support for Embeddables (VOs). #8349

New Issue

admin · 2026-01-22T15:59:31+01:00

admin commented

2026-01-22 15:59:31 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/547
Author: @Burgov
Created: 1/10/2013
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (9)

5ef2395 Mapping support for Embeddables (VOs).
d519074 First round of refactorings after initial commit about VOs implementation after some valuable comments.
cc960ba More work around Value Objects.
24fdf9f Merge remote-tracking branch 'upstream/DDC-93'
619ab4c fixed isEntity method
d655880 switched to correct license
5805602 fixed code formatting
a971f65 removed debug code
86daa87 fixed grammatics to be consistent with other methods

📊 Changes

19 files changed (+602 additions, -75 deletions)

View changed files

📝 doctrine-mapping.xsd (+58 -34)
📝 lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php (+29 -5)
📝 lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php (+235 -21)
📝 lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php (+18 -4)
📝 lib/Doctrine/ORM/Mapping/Driver/DoctrineAnnotations.php (+2 -0)
📝 lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php (+20 -0)
📝 lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php (+19 -0)
➕ lib/Doctrine/ORM/Mapping/Embeddable.php (+28 -0)
➕ lib/Doctrine/ORM/Mapping/Embedded.php (+33 -0)
📝 lib/Doctrine/ORM/Mapping/MappingException.php (+27 -1)
📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+23 -9)
📝 lib/Doctrine/ORM/Persisters/JoinedSubclassPersister.php (+8 -0)
📝 lib/Doctrine/ORM/Tools/SchemaTool.php (+31 -0)
➕ tests/Doctrine/Tests/Models/CMS/CmsParents.php (+34 -0)
📝 tests/Doctrine/Tests/Models/CMS/CmsUser.php (+4 -0)
📝 tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php (+24 -0)
📝 tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.ORM.Mapping.User.php (+4 -0)
📝 tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.ORM.Mapping.User.dcm.xml (+1 -0)
📝 tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.ORM.Mapping.User.dcm.yml (+4 -1)

📄 Description

I decided to merge #265 onto master in order to revive the branch. We're going to be in desperate need for something similar to this soon.

However, I'm getting a lot of errors by PHPUnit, so I clearly missed something. Can anyone tell me what needs to happen to get this stable again?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/547 **Author:** [@Burgov](https://github.com/Burgov) **Created:** 1/10/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`5ef2395`](https://github.com/doctrine/orm/commit/5ef2395dee388721885f5280455d8a60c9f4fa7f) Mapping support for Embeddables (VOs). - [`d519074`](https://github.com/doctrine/orm/commit/d519074e1838189c554d006749c48632871dcc59) First round of refactorings after initial commit about VOs implementation after some valuable comments. - [`cc960ba`](https://github.com/doctrine/orm/commit/cc960bab8552c1f376bef6234822f6eb6a173855) More work around Value Objects. - [`24fdf9f`](https://github.com/doctrine/orm/commit/24fdf9fae3fc6501da8a497947b4bc2b34ce57fa) Merge remote-tracking branch 'upstream/DDC-93' - [`619ab4c`](https://github.com/doctrine/orm/commit/619ab4c66e8c1d7b99bf68e0c8eeacd5e065c836) fixed isEntity method - [`d655880`](https://github.com/doctrine/orm/commit/d65588050719b2ad52cfdc2e9f99810e1c600570) switched to correct license - [`5805602`](https://github.com/doctrine/orm/commit/5805602e3523a1de53bd17bf6a3368ba0c2bb669) fixed code formatting - [`a971f65`](https://github.com/doctrine/orm/commit/a971f6544ea549f17fb3788d7b3334b58e76a7c5) removed debug code - [`86daa87`](https://github.com/doctrine/orm/commit/86daa87c0130aa188047eb2f8194ab42f68cfb6b) fixed grammatics to be consistent with other methods ### 📊 Changes **19 files changed** (+602 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `doctrine-mapping.xsd` (+58 -34) 📝 `lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php` (+29 -5) 📝 `lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php` (+235 -21) 📝 `lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php` (+18 -4) 📝 `lib/Doctrine/ORM/Mapping/Driver/DoctrineAnnotations.php` (+2 -0) 📝 `lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php` (+20 -0) 📝 `lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php` (+19 -0) ➕ `lib/Doctrine/ORM/Mapping/Embeddable.php` (+28 -0) ➕ `lib/Doctrine/ORM/Mapping/Embedded.php` (+33 -0) 📝 `lib/Doctrine/ORM/Mapping/MappingException.php` (+27 -1) 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+23 -9) 📝 `lib/Doctrine/ORM/Persisters/JoinedSubclassPersister.php` (+8 -0) 📝 `lib/Doctrine/ORM/Tools/SchemaTool.php` (+31 -0) ➕ `tests/Doctrine/Tests/Models/CMS/CmsParents.php` (+34 -0) 📝 `tests/Doctrine/Tests/Models/CMS/CmsUser.php` (+4 -0) 📝 `tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php` (+24 -0) 📝 `tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.ORM.Mapping.User.php` (+4 -0) 📝 `tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.ORM.Mapping.User.dcm.xml` (+1 -0) 📝 `tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.ORM.Mapping.User.dcm.yml` (+4 -1) </details> ### 📄 Description I decided to merge #265 onto master in order to revive the branch. We're going to be in desperate need for something similar to this soon. However, I'm getting a lot of errors by PHPUnit, so I clearly missed something. Can anyone tell me what needs to happen to get this stable again? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:59:31 +01:00

admin closed this issue

2026-01-22 15:59:31 +01:00

admin referenced this issue

2026-01-22 16:09:10 +01:00

[PR #8349] Fix commit order #10937

admin referenced this issue

2026-01-22 16:14:04 +01:00

[PR #10547] Compute the commit order (inserts/deletes) on the entity level #12445

Sign in to join this conversation.