mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
[PR #523] [MERGED] [DDC-2074] Bugfix regarding clearing cloned PersistentCollections #8324
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/doctrine/orm/pull/523
Author: @jankramer
Created: 11/25/2012
Status: ✅ Merged
Merged: 11/25/2012
Merged by: @beberlei
Base:
master← Head:DDC-2074📝 Commits (2)
9b78100[DDC-2074] Added test for PersistentCollection#clear.5b3f544[DDC-2074] Fixed bug regarding clearing PC's without owner📊 Changes
2 files changed (+30 additions, -1 deletions)
View changed files
📝
lib/Doctrine/ORM/PersistentCollection.php(+1 -1)➕
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2074Test.php(+29 -0)📄 Description
When calling clear on a PC that has no owner (e.g. because it was cloned), it can't be deleted as there is no metadata available (that's essentially the exception mentioned in the ticket). In these cases, I think it shouldn't be scheduled for deletion, but please have a look as my knowledge of the ORM internals is limited.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.