[PR #508] [MERGED] Fix and test for DDC-2073 #8307

New Issue

admin · 2026-01-22T15:59:19+01:00

admin commented

2026-01-22 15:59:19 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/508
Author: @mnapoli
Created: 11/6/2012
Status: ✅ Merged
Merged: 11/6/2012
Merged by: @guilhermeblanco

Base: master ← Head: DDC-2073

📝 Commits (2)

e15cf32 Fix and test for DDC-2073
c2d9197 Fix and test for DDC-2073

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+1 -1)
📝 tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php (+10 -0)

📄 Description

Fix and test for DDC-2073.

Ticket extract:

PersistentCollection::matching() always returns empty collection, when passed criteria's expression is created using ExpressionBuilder::isNull()
This happens because expression created by ExpressionBuilder::isNull() is wrongly translated to SQL using '=' operator instead of 'IS NULL'.
If the collection is already loaded, result is as expected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/508 **Author:** [@mnapoli](https://github.com/mnapoli) **Created:** 11/6/2012 **Status:** ✅ Merged **Merged:** 11/6/2012 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `DDC-2073` --- ### 📝 Commits (2) - [`e15cf32`](https://github.com/doctrine/orm/commit/e15cf324c32a302c16d1cb68f91b79d232a98445) Fix and test for DDC-2073 - [`c2d9197`](https://github.com/doctrine/orm/commit/c2d9197900543f1c40bcc8eecc0e5b81af4acdfd) Fix and test for DDC-2073 ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php` (+10 -0) </details> ### 📄 Description Fix and test for [DDC-2073](http://www.doctrine-project.org/jira/browse/DDC-2073). Ticket extract: > PersistentCollection::matching() always returns empty collection, when passed criteria's expression is created using ExpressionBuilder::isNull() > This happens because expression created by ExpressionBuilder::isNull() is wrongly translated to SQL using '=' operator instead of 'IS NULL'. > If the collection is already loaded, result is as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:59:19 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8307