doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-04-29 09:23:20 +02:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #495] [CLOSED] [DDC-2113] Surround WHERE clause with parens if using SQLFilter #8282

New Issue
Open
opened 2026-01-22 15:59:12 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:59:12 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/495
Author: @vclayton
Created: 11/1/2012
Status: ❌ Closed

Base: 2.2 ← Head: DDC-2113

📝 Commits (10+)

  • 7807d68 fix delete join table not owning side
  • 51f29cd fix delete join table
  • cd806b8 fix DDC-142 persist OneToOne
  • e0a236a fix DDC-142 load OneToOne EAGER
  • b6b35d9 test quote join variable
  • 85b6f8d change quote strategy to interface
  • ea69048 revert wrong change
  • ab9ff81 revert submodule change
  • 49f9d18 Fix CS and test configuration
  • b9d94e7 add DefaultQuoteStrategy use statement

📊 Changes

488 files changed (+22961 additions, -6275 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 .gitmodules (+1 -1)
📝 LICENSE (+19 -504)
📝 README.markdown (+3 -2)
➕ UPGRADE.md (+467 -0)
➖ UPGRADE_TO_2_0 (+0 -240)
➖ UPGRADE_TO_2_1 (+0 -25)
➖ UPGRADE_TO_2_2 (+0 -76)
➖ UPGRADE_TO_ALPHA3 (+0 -35)
➖ UPGRADE_TO_ALPHA4 (+0 -36)
📝 bin/doctrine (+1 -1)
➕ bin/doctrine-pear.php (+50 -0)
📝 bin/doctrine.php (+1 -8)
📝 build.xml (+2 -2)
📝 composer.json (+13 -4)
📝 doctrine-mapping.xsd (+113 -2)
📝 lib/Doctrine/ORM/AbstractQuery.php (+255 -82)
📝 lib/Doctrine/ORM/Configuration.php (+208 -76)
📝 lib/Doctrine/ORM/EntityManager.php (+112 -44)
📝 lib/Doctrine/ORM/EntityNotFoundException.php (+2 -2)

...and 80 more files

📄 Description

Patch to address DDC-2113, by surrounding the WHERE clause conditional with parens if there are any filterClauses

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/495 **Author:** [@vclayton](https://github.com/vclayton) **Created:** 11/1/2012 **Status:** ❌ Closed **Base:** `2.2` ← **Head:** `DDC-2113` --- ### 📝 Commits (10+) - [`7807d68`](https://github.com/doctrine/orm/commit/7807d6806c969113ff41a028ffa2a306fc889f63) fix delete join table not owning side - [`51f29cd`](https://github.com/doctrine/orm/commit/51f29cddb9b0b4c041748df8c372bc1c906d9623) fix delete join table - [`cd806b8`](https://github.com/doctrine/orm/commit/cd806b83db61c9671bd30c1beeb3c02e11e3b32f) fix DDC-142 persist OneToOne - [`e0a236a`](https://github.com/doctrine/orm/commit/e0a236a9af18519f94512aa4f073d2f287e6ed91) fix DDC-142 load OneToOne EAGER - [`b6b35d9`](https://github.com/doctrine/orm/commit/b6b35d9482e37bba7f7670d7ee371eb9ea8c3b9c) test quote join variable - [`85b6f8d`](https://github.com/doctrine/orm/commit/85b6f8dc2ff45d8e3333d49db459bd44bb5f8212) change quote strategy to interface - [`ea69048`](https://github.com/doctrine/orm/commit/ea690489d750e17245d284bc92504dc1238ad308) revert wrong change - [`ab9ff81`](https://github.com/doctrine/orm/commit/ab9ff813fc20e897348225484fa3b60abf15538a) revert submodule change - [`49f9d18`](https://github.com/doctrine/orm/commit/49f9d185deaa084301d6f9c736de363b93254e6a) Fix CS and test configuration - [`b9d94e7`](https://github.com/doctrine/orm/commit/b9d94e7bf0c0d6dd57d1eb04a36f499c2400c8ba) add DefaultQuoteStrategy use statement ### 📊 Changes **488 files changed** (+22961 additions, -6275 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `.gitmodules` (+1 -1) 📝 `LICENSE` (+19 -504) 📝 `README.markdown` (+3 -2) ➕ `UPGRADE.md` (+467 -0) ➖ `UPGRADE_TO_2_0` (+0 -240) ➖ `UPGRADE_TO_2_1` (+0 -25) ➖ `UPGRADE_TO_2_2` (+0 -76) ➖ `UPGRADE_TO_ALPHA3` (+0 -35) ➖ `UPGRADE_TO_ALPHA4` (+0 -36) 📝 `bin/doctrine` (+1 -1) ➕ `bin/doctrine-pear.php` (+50 -0) 📝 `bin/doctrine.php` (+1 -8) 📝 `build.xml` (+2 -2) 📝 `composer.json` (+13 -4) 📝 `doctrine-mapping.xsd` (+113 -2) 📝 `lib/Doctrine/ORM/AbstractQuery.php` (+255 -82) 📝 `lib/Doctrine/ORM/Configuration.php` (+208 -76) 📝 `lib/Doctrine/ORM/EntityManager.php` (+112 -44) 📝 `lib/Doctrine/ORM/EntityNotFoundException.php` (+2 -2) _...and 80 more files_ </details> ### 📄 Description Patch to address DDC-2113, by surrounding the WHERE clause conditional with parens if there are any filterClauses --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:59:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?