doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #485] [CLOSED] Back ported changes of SimpleConditionalExpression #8265

New Issue
Open
opened 2026-01-22 15:59:08 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:59:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/485
Author: @sstok
Created: 10/19/2012
Status: ❌ Closed

Base: 2.2 ← Head: patch1

📝 Commits (1)

  • d169ffa Back ported changes of SimpleConditionalExpression

📊 Changes

1 file changed (+12 additions, -3 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/Parser.php (+12 -3)

📄 Description

This following query fails.

SELECT I FROM Rollerworks\Bundle\RecordFilterBundle\Tests\Fixtures\BaseBundle\Entity\ECommerce\ECommerceInvoice I WHERE ((RECORD_FILTER_FIELD_CONVERSION('invoice_customer', I.customer) BETWEEN :invoice_customer_0 AND :invoice_customer_1) AND (RECORD_FILTER_FIELD_CONVERSION('invoice_customer', I.customer) NOT BETWEEN :invoice_customer_2 AND :invoice_customer_3))

With this message.

[Syntax Error] line 0, col 306: Error: Expected =, <, <=, <>, >, >=, !=, got 'NOT'

It only happens in version 2.2, 2.3 is working as expected.

I have traced the fix to one very simple change in SimpleConditionalExpression and only seem to happen when using an custom function NOT and having nested parenthesis.

As far as I can tell its BC.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/485 **Author:** [@sstok](https://github.com/sstok) **Created:** 10/19/2012 **Status:** ❌ Closed **Base:** `2.2` ← **Head:** `patch1` --- ### 📝 Commits (1) - [`d169ffa`](https://github.com/doctrine/orm/commit/d169ffa91cac7b0a8c263ea74857a206b5c4aa78) Back ported changes of SimpleConditionalExpression ### 📊 Changes **1 file changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/Parser.php` (+12 -3) </details> ### 📄 Description This following query fails. ``` SELECT I FROM Rollerworks\Bundle\RecordFilterBundle\Tests\Fixtures\BaseBundle\Entity\ECommerce\ECommerceInvoice I WHERE ((RECORD_FILTER_FIELD_CONVERSION('invoice_customer', I.customer) BETWEEN :invoice_customer_0 AND :invoice_customer_1) AND (RECORD_FILTER_FIELD_CONVERSION('invoice_customer', I.customer) NOT BETWEEN :invoice_customer_2 AND :invoice_customer_3)) ``` With this message. ``` [Syntax Error] line 0, col 306: Error: Expected =, <, <=, <>, >, >=, !=, got 'NOT' ``` It only happens in version 2.2, 2.3 is working as expected. I have traced the fix to one very simple change in SimpleConditionalExpression and only seem to happen when using an custom function NOT and having nested parenthesis. As far as I can tell its BC. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:59:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?