[PR #471] [MERGED] Extended TreeWalker interface with getQueryComponents() and setQueryComponent() which are used by the Parser class #8245

New Issue

admin · 2026-01-22T15:59:02+01:00

admin commented

2026-01-22 15:59:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/471
Author: @chives
Created: 10/11/2012
Status: ✅ Merged
Merged: 11/22/2012
Merged by: @guilhermeblanco

Base: master ← Head: DDC-2052

📝 Commits (4)

2c99ecf Extended TreeWalker interface with getQueryComponenets() and setQueryComponent() which are used by the Parser class
7b1d84c Moved CustomTreeWalkersJoinTest to proper namespace and fixed licence
08a3423 CS fixes
afdb92f Added note about new methods in UPGRADE.md

📊 Changes

7 files changed (+204 additions, -5 deletions)

View changed files

📝 UPGRADE.md (+6 -0)
📝 lib/Doctrine/ORM/Query/Parser.php (+4 -2)
📝 lib/Doctrine/ORM/Query/SqlWalker.php (+13 -3)
📝 lib/Doctrine/ORM/Query/TreeWalker.php (+15 -0)
📝 lib/Doctrine/ORM/Query/TreeWalkerAdapter.php (+27 -0)
📝 lib/Doctrine/ORM/Query/TreeWalkerChain.php (+29 -0)
➕ tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersJoinTest.php (+110 -0)

📄 Description

Another proposed solution for http://www.doctrine-project.org/jira/browse/DDC-2052 . The one that @beberlei introduced did not solve the problem that modifying query in a custom tree walker throws an exception from SqlWalker.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/471 **Author:** [@chives](https://github.com/chives) **Created:** 10/11/2012 **Status:** ✅ Merged **Merged:** 11/22/2012 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `DDC-2052` --- ### 📝 Commits (4) - [`2c99ecf`](https://github.com/doctrine/orm/commit/2c99ecf5862ee36864d1427e54d7f74d58470fe7) Extended TreeWalker interface with getQueryComponenets() and setQueryComponent() which are used by the Parser class - [`7b1d84c`](https://github.com/doctrine/orm/commit/7b1d84cbdb8002428a9550264919ee5f05c13113) Moved CustomTreeWalkersJoinTest to proper namespace and fixed licence - [`08a3423`](https://github.com/doctrine/orm/commit/08a3423ce20a269db10bf3f05ace10e2ea4926c0) CS fixes - [`afdb92f`](https://github.com/doctrine/orm/commit/afdb92ff9b7d46bc1b314260b667be83ecfe9797) Added note about new methods in UPGRADE.md ### 📊 Changes **7 files changed** (+204 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `UPGRADE.md` (+6 -0) 📝 `lib/Doctrine/ORM/Query/Parser.php` (+4 -2) 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+13 -3) 📝 `lib/Doctrine/ORM/Query/TreeWalker.php` (+15 -0) 📝 `lib/Doctrine/ORM/Query/TreeWalkerAdapter.php` (+27 -0) 📝 `lib/Doctrine/ORM/Query/TreeWalkerChain.php` (+29 -0) ➕ `tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersJoinTest.php` (+110 -0) </details> ### 📄 Description Another proposed solution for http://www.doctrine-project.org/jira/browse/DDC-2052 . The one that @beberlei introduced did not solve the problem that modifying query in a custom tree walker throws an exception from SqlWalker. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:59:02 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8245