doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #464] [CLOSED] Fill queryComponents with missing components (i.e added by some TreeWalker) in walkSelectStatement() #8233

New Issue
Closed
opened 2026-01-22 15:59:00 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:59:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/464
Author: @chives
Created: 10/4/2012
Status: ❌ Closed

Base: master ← Head: DDC-2052

📝 Commits (2)

  • 87bf979 Fill queryComponents with missing components (i.e added by some TreeWalker) in walkSelectStatement()
  • 4cd889b Added test for DDC-2052

📊 Changes

2 files changed (+135 additions, -0 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/SqlWalker.php (+35 -0)
➕ tests/Doctrine/Tests/ORM/Functional/CustomTreeWalkersJoinTest.php (+100 -0)

📄 Description

Proposed solution for http://www.doctrine-project.org/jira/browse/DDC-2052 .
This is some kind of temporary (backward compatible) solution for this problem. In my opinion it's worth to think about changing some interfaces in order to solve this in more elegant way.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/464 **Author:** [@chives](https://github.com/chives) **Created:** 10/4/2012 **Status:** ❌ Closed **Base:** `master` ← **Head:** `DDC-2052` --- ### 📝 Commits (2) - [`87bf979`](https://github.com/doctrine/orm/commit/87bf9797742c292e05c09848702d404c1182d226) Fill queryComponents with missing components (i.e added by some TreeWalker) in walkSelectStatement() - [`4cd889b`](https://github.com/doctrine/orm/commit/4cd889b6a635bc910ec9c702c3d28a246decf88d) Added test for DDC-2052 ### 📊 Changes **2 files changed** (+135 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+35 -0) ➕ `tests/Doctrine/Tests/ORM/Functional/CustomTreeWalkersJoinTest.php` (+100 -0) </details> ### 📄 Description Proposed solution for http://www.doctrine-project.org/jira/browse/DDC-2052 . This is some kind of temporary (backward compatible) solution for this problem. In my opinion it's worth to think about changing some interfaces in order to solve this in more elegant way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:59:00 +01:00
admin closed this issue 2026-01-22 15:59:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8233
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?