[PR #449] [MERGED] Pager fix for DDC-1958 #8211

New Issue

admin · 2026-01-22T15:58:54+01:00

admin commented

2026-01-22 15:58:54 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/449
Author: @mvrhov
Created: 9/18/2012
Status: ✅ Merged
Merged: 11/12/2012
Merged by: @beberlei

Base: master ← Head: DDC-1958

📝 Commits (2)

c7a75f4 The distinct query should replicate the fields in order by clause and the order by clause itself from inner query
8fe9fa0 extracted pgsql sql generation into a helper method

📊 Changes

4 files changed (+94 additions, -3 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php (+51 -2)
📝 tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php (+29 -1)
📝 tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryWalkerTest.php (+12 -0)
📝 tests/Doctrine/Tests/ORM/Tools/Pagination/PaginationTestCase.php (+2 -0)

📄 Description

This fixes the LimitSubqueryOutputWalker of pager for just for the postgresql.

Any chances of getting this into 2.3?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/449 **Author:** [@mvrhov](https://github.com/mvrhov) **Created:** 9/18/2012 **Status:** ✅ Merged **Merged:** 11/12/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `DDC-1958` --- ### 📝 Commits (2) - [`c7a75f4`](https://github.com/doctrine/orm/commit/c7a75f477f9f1d3aad79ab1f5d7c42a4cf166cfd) The distinct query should replicate the fields in order by clause and the order by clause itself from inner query - [`8fe9fa0`](https://github.com/doctrine/orm/commit/8fe9fa0dc7d62ba9f9a4157c643c73d8c7436fbd) extracted pgsql sql generation into a helper method ### 📊 Changes **4 files changed** (+94 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php` (+51 -2) 📝 `tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php` (+29 -1) 📝 `tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryWalkerTest.php` (+12 -0) 📝 `tests/Doctrine/Tests/ORM/Tools/Pagination/PaginationTestCase.php` (+2 -0) </details> ### 📄 Description This fixes the LimitSubqueryOutputWalker of pager for just for the postgresql. Any chances of getting this into 2.3? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:58:54 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8211