[PR #451] [CLOSED] Adding multiple identical joins via query builder should produce a valid DQL #8210

Open
opened 2026-01-22 15:58:54 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/451
Author: @mvrhov
Created: 9/21/2012
Status: Closed

Base: masterHead: ignoreIdenticalJoins


📝 Commits (1)

  • 3edf8dc Adding multiple identical joins via query builder should produce a valid DQL

📊 Changes

2 files changed (+29 additions, -0 deletions)

View changed files

📝 lib/Doctrine/ORM/QueryBuilder.php (+17 -0)
📝 tests/Doctrine/Tests/ORM/QueryBuilderTest.php (+12 -0)

📄 Description

Rationale:
I'm building a webservice where the client can specify a simple filter on the field of the 1:n table.
Without this patch I have to keep a state of which joins I have added to the DQL, which doesn't make any sense as IMHO the DQL builder is meant just for the kind of usage I do.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/451 **Author:** [@mvrhov](https://github.com/mvrhov) **Created:** 9/21/2012 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ignoreIdenticalJoins` --- ### 📝 Commits (1) - [`3edf8dc`](https://github.com/doctrine/orm/commit/3edf8dc6729a04467a33d1ed5ea90e036ee09146) Adding multiple identical joins via query builder should produce a valid DQL ### 📊 Changes **2 files changed** (+29 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/QueryBuilder.php` (+17 -0) 📝 `tests/Doctrine/Tests/ORM/QueryBuilderTest.php` (+12 -0) </details> ### 📄 Description Rationale: I'm building a webservice where the client can specify a simple filter on the field of the 1:n table. Without this patch I have to keep a state of which joins I have added to the DQL, which doesn't make any sense as IMHO the DQL builder is meant just for the kind of usage I do. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:58:54 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8210