[PR #428] [MERGED] Add QueryBuilder::addCriteria() for Criteria - QueryBuilder bridge #8181

New Issue

admin · 2026-01-22T15:58:46+01:00

admin commented

2026-01-22 15:58:46 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/428
Author: @chEbba
Created: 8/20/2012
Status: ✅ Merged
Merged: 8/29/2012
Merged by: @beberlei

Base: master ← Head: query-builder-common-criteria

📝 Commits (8)

c6b3899 Add QueryBuilder::addCriteria() for Criteria - QueryBuilder bridge
1487896 Remove unnecessary else statements after if with return in QueryExpressionVisitor
d3ab948 Overwrite query limits only if set in QueryBuilder::addCriteria()
433d208 Remove extra space from QueryBuilder::addCriteria()
1c2f2b5 Store QueryExpressionVisitor parameters as array
2aba7fb Add test for QueryBuilderTest::addCriteria with undefined limits
a162f00 Remove builders from QueryExpressionVisitorTest constructor
e68807a Change version for QueryExpressionVisitor

📊 Changes

4 files changed (+395 additions, -1 deletions)

View changed files

➕ lib/Doctrine/ORM/Query/QueryExpressionVisitor.php (+168 -0)
📝 lib/Doctrine/ORM/QueryBuilder.php (+39 -0)
➕ tests/Doctrine/Tests/ORM/Query/QueryExpressionVisitorTest.php (+134 -0)
📝 tests/Doctrine/Tests/ORM/QueryBuilderTest.php (+54 -1)

📄 Description

Simple implementation of Criteria to QueryBuilder conversion. Small step for Criteria integration without BC break.

Recreated from #426

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/428 **Author:** [@chEbba](https://github.com/chEbba) **Created:** 8/20/2012 **Status:** ✅ Merged **Merged:** 8/29/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `query-builder-common-criteria` --- ### 📝 Commits (8) - [`c6b3899`](https://github.com/doctrine/orm/commit/c6b3899c2da7161a69ae943d86229f78f236ad3c) Add QueryBuilder::addCriteria() for Criteria - QueryBuilder bridge - [`1487896`](https://github.com/doctrine/orm/commit/148789600a8472387c90200483d64b175e08cb94) Remove unnecessary else statements after if with return in QueryExpressionVisitor - [`d3ab948`](https://github.com/doctrine/orm/commit/d3ab948d88b2e555878ab329440f14fa903eb133) Overwrite query limits only if set in QueryBuilder::addCriteria() - [`433d208`](https://github.com/doctrine/orm/commit/433d2085727741edcefcbb794513fb82cc6abd5c) Remove extra space from QueryBuilder::addCriteria() - [`1c2f2b5`](https://github.com/doctrine/orm/commit/1c2f2b5c136a1c0b082bbf0a61928d64bec2cef8) Store QueryExpressionVisitor parameters as array - [`2aba7fb`](https://github.com/doctrine/orm/commit/2aba7fb3746c30baf286b9ebe64b83a33df28d44) Add test for QueryBuilderTest::addCriteria with undefined limits - [`a162f00`](https://github.com/doctrine/orm/commit/a162f00eccb684861dd0acd8d863470eef6923d4) Remove builders from QueryExpressionVisitorTest constructor - [`e68807a`](https://github.com/doctrine/orm/commit/e68807ad4ff620ade64d5a05ba241832b0e1dc51) Change version for QueryExpressionVisitor ### 📊 Changes **4 files changed** (+395 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `lib/Doctrine/ORM/Query/QueryExpressionVisitor.php` (+168 -0) 📝 `lib/Doctrine/ORM/QueryBuilder.php` (+39 -0) ➕ `tests/Doctrine/Tests/ORM/Query/QueryExpressionVisitorTest.php` (+134 -0) 📝 `tests/Doctrine/Tests/ORM/QueryBuilderTest.php` (+54 -1) </details> ### 📄 Description Simple implementation of Criteria to QueryBuilder conversion. Small step for Criteria integration without BC break. Recreated from #426 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:58:46 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8181