doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #413] [MERGED] code refactorings on persister #8156

New Issue
Open
opened 2026-01-22 15:58:41 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:58:41 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/413
Author: @FabioBatSilva
Created: 7/29/2012
Status: ✅ Merged
Merged: 11/25/2012
Merged by: @beberlei

Base: master ← Head: refactory-persisters

📝 Commits (10+)

  • b998a52 remove '_' prefix at BasicEntityPersister
  • e6f08f0 remove '_' prefix at AbstractCollectionPersister
  • 7e348b7 small refacory on AbstractEntityInheritancePersister
  • 308b54a code refactoring on BasicEntityPersister
  • 3156c15 code refactoring on JoinedSubclassPersister
  • 07492bd fix JoinedSubclassPersister#delete when supports foreign key
  • 2b1aaeb code refactoring on ManyToManyPersister
  • 9a041c8 code refactoring on OneToManyPersister
  • 14a2b61 code refactoring on SingleTablePersister
  • 04e1838 change 'use' statements

📊 Changes

10 files changed (+1267 additions, -1035 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php (+99 -37)
📝 lib/Doctrine/ORM/Persisters/AbstractEntityInheritancePersister.php (+16 -13)
📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+625 -554)
📝 lib/Doctrine/ORM/Persisters/ElementCollectionPersister.php (+1 -1)
📝 lib/Doctrine/ORM/Persisters/JoinedSubclassPersister.php (+287 -227)
📝 lib/Doctrine/ORM/Persisters/ManyToManyPersister.php (+78 -72)
���� lib/Doctrine/ORM/Persisters/OneToManyPersister.php (+56 -45)
📝 lib/Doctrine/ORM/Persisters/SingleTablePersister.php (+75 -56)
📝 tests/Doctrine/Tests/Mocks/EntityPersisterMock.php (+27 -27)
📝 tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php (+3 -3)

📄 Description

hi

This patch does not add any feature, just small refactorings and code clean up.
It make easier to implement the generation of persisters:
http://www.doctrine-project.org/jira/browse/DDC-1889

Cheers ...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/413 **Author:** [@FabioBatSilva](https://github.com/FabioBatSilva) **Created:** 7/29/2012 **Status:** ✅ Merged **Merged:** 11/25/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `refactory-persisters` --- ### 📝 Commits (10+) - [`b998a52`](https://github.com/doctrine/orm/commit/b998a522b030c154eac161ba7effd99133a09c73) remove '_' prefix at BasicEntityPersister - [`e6f08f0`](https://github.com/doctrine/orm/commit/e6f08f0b9219bfb948c07b24f7fef5257954edf7) remove '_' prefix at AbstractCollectionPersister - [`7e348b7`](https://github.com/doctrine/orm/commit/7e348b7815d8d0d161a53dcb617c084b92be212e) small refacory on AbstractEntityInheritancePersister - [`308b54a`](https://github.com/doctrine/orm/commit/308b54a8f3904139a2d9ad590093b3c562d999c0) code refactoring on BasicEntityPersister - [`3156c15`](https://github.com/doctrine/orm/commit/3156c1549dd4aaa3fbff244ff40a6b7aa7a3a289) code refactoring on JoinedSubclassPersister - [`07492bd`](https://github.com/doctrine/orm/commit/07492bda9db79f35b832a263bcbeecdb870effe2) fix JoinedSubclassPersister#delete when supports foreign key - [`2b1aaeb`](https://github.com/doctrine/orm/commit/2b1aaebe18e2fb2071cf85422891494e1518ba09) code refactoring on ManyToManyPersister - [`9a041c8`](https://github.com/doctrine/orm/commit/9a041c8fdbb2ee92e40f00285a52b3c76f56c61c) code refactoring on OneToManyPersister - [`14a2b61`](https://github.com/doctrine/orm/commit/14a2b616716bdc1c774d020758791d8154f8bffa) code refactoring on SingleTablePersister - [`04e1838`](https://github.com/doctrine/orm/commit/04e1838c9249bf366e0c01c7ff2109aa2e9c44f2) change 'use' statements ### 📊 Changes **10 files changed** (+1267 additions, -1035 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php` (+99 -37) 📝 `lib/Doctrine/ORM/Persisters/AbstractEntityInheritancePersister.php` (+16 -13) 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+625 -554) 📝 `lib/Doctrine/ORM/Persisters/ElementCollectionPersister.php` (+1 -1) 📝 `lib/Doctrine/ORM/Persisters/JoinedSubclassPersister.php` (+287 -227) 📝 `lib/Doctrine/ORM/Persisters/ManyToManyPersister.php` (+78 -72) ���� `lib/Doctrine/ORM/Persisters/OneToManyPersister.php` (+56 -45) 📝 `lib/Doctrine/ORM/Persisters/SingleTablePersister.php` (+75 -56) 📝 `tests/Doctrine/Tests/Mocks/EntityPersisterMock.php` (+27 -27) 📝 `tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php` (+3 -3) </details> ### 📄 Description hi This patch does not add any feature, just small refactorings and code clean up. It make easier to implement the generation of persisters: http://www.doctrine-project.org/jira/browse/DDC-1889 Cheers ... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:58:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?