[PR #376] [MERGED] De-deprecate transaction handling methods #8101

New Issue

admin · 2026-01-22T15:58:23+01:00

admin commented

2026-01-22 15:58:23 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/376
Author: @lstrojny
Created: 6/16/2012
Status: ✅ Merged
Merged: 7/4/2012
Merged by: @beberlei

Base: master ← Head: de-deprecate-transaction-methods

📝 Commits (1)

3881e12 De-deprecate transaction handling methods

📊 Changes

1 file changed (+0 additions, -6 deletions)

View changed files

📝 lib/Doctrine/ORM/EntityManager.php (+0 -6)

📄 Description

As discussed with @beberlei over IRC, deprecating transaction handling methods make the API cleaner but testing of Entity Manager dependent components much messier. Also suggesting to use $em->getConnection()->beginTransaction() feels like a violation of the law of demeter.

Therefore this pull request would remove the deprecation warnings from EntityManager::beginTransaction(), EntityManager::commit(), EntityManager::rollback().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/376 **Author:** [@lstrojny](https://github.com/lstrojny) **Created:** 6/16/2012 **Status:** ✅ Merged **Merged:** 7/4/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `de-deprecate-transaction-methods` --- ### 📝 Commits (1) - [`3881e12`](https://github.com/doctrine/orm/commit/3881e12a2d703a0bf620107b4515df1e52104e81) De-deprecate transaction handling methods ### 📊 Changes **1 file changed** (+0 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/EntityManager.php` (+0 -6) </details> ### 📄 Description As discussed with @beberlei over IRC, deprecating transaction handling methods make the API cleaner but testing of Entity Manager dependent components much messier. Also suggesting to use `$em->getConnection()->beginTransaction()` feels like a violation of the law of demeter. Therefore this pull request would remove the deprecation warnings from `EntityManager::beginTransaction()`, `EntityManager::commit()`, `EntityManager::rollback()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:58:23 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8101