[PR #372] [DDC-1845] QuoteStrategy #8096

New Issue

Open

opened 2026-01-22 15:58:22 +01:00 by admin · 0 comments

admin commented 2026-01-22 15:58:22 +01:00

Owner

Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/372

State: closed
Merged: Yes

---

QuoteStrategy

http://www.doctrine-project.org/jira/browse/DDC-1845

This patch fix some quote problems using a default quote strategy and allows users find solutions themselves for weird quote cases.

This DBAL PR shoud be merged to fix sqlite tests in : https://github.com/doctrine/dbal/pull/158

There is a lote of new method calls, the performance tests in sqlite are the following :

My branch :

. testSimpleQueryScalarHydrationPerformance10000Rows - 0.37292098999023 seconds
. testSimpleQueryArrayHydrationPerformance10000Rows - 0.50411009788513 seconds
. testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.1323919296265 seconds
. testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.0243051052094 seconds
. testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1673181056976 seconds
. testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.40403699874878 seconds
. testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.873291015625 seconds
. 99 CompanyContract: 0.023395
. 99 CompanyContract: 0.019528
. Memory usage before: 111715.53125 KB
. Memory usage after: 110282.875 KB
. Inserted 10000 objects in 5.5240259170532 seconds
. 100 CmsArticle findAll(): 0.018410
. 100 CmsArticle findAll(): 0.014157
. 100 CmsArticle find(): 0.043304
. 100 CmsArticle find(): 0.041451
. 100 CmsGroup: 0.009315
. 100 CmsGroup: 0.009239
. 100 CmsUser: 0.024051
. 100 CmsUser: 0.023655
. Compute ChangeSet 100 objects in 0.040482997894287 seconds

. Time: 19 seconds, Memory: 261.50Mb

Doctrine Master :

. testSimpleQueryScalarHydrationPerformance10000Rows - 0.37668490409851 seconds
. testSimpleQueryArrayHydrationPerformance10000Rows - 0.5009880065918 seconds
. testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.131824016571 seconds
. testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.037791967392 seconds
. testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1992859840393 seconds
. testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.41158103942871 seconds
. testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.86575293540955 seconds
. 99 CompanyContract: 0.023206
. 99 CompanyContract: 0.020555
. Inserted 10000 objects in 5.4995818138123 seconds
. 100 CmsArticle findAll(): 0.018785
. 100 CmsArticle findAll(): 0.014160
. 100 CmsArticle find(): 0.042067
. 100 CmsArticle find(): 0.041076
. 100 CmsGroup: 0.009478
. 100 CmsGroup: 0.010591
. 100 CmsUser: 0.023727
. 100 CmsUser: 0.023073
. Compute ChangeSet 100 objects in 0.040009021759033 seconds

. Time: 19 seconds, Memory: 260.50Mb

**Original Pull Request:** https://github.com/doctrine/orm/pull/372 **State:** closed **Merged:** Yes --- ### QuoteStrategy http://www.doctrine-project.org/jira/browse/DDC-1845 This patch fix some quote problems using a default quote strategy and allows users find solutions themselves for weird quote cases. This DBAL PR shoud be merged to fix sqlite tests in : https://github.com/doctrine/dbal/pull/158 There is a lote of new method calls, the performance tests in sqlite are the following : #### My branch : ``` . testSimpleQueryScalarHydrationPerformance10000Rows - 0.37292098999023 seconds . testSimpleQueryArrayHydrationPerformance10000Rows - 0.50411009788513 seconds . testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.1323919296265 seconds . testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.0243051052094 seconds . testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1673181056976 seconds . testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.40403699874878 seconds . testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.873291015625 seconds . 99 CompanyContract: 0.023395 . 99 CompanyContract: 0.019528 . Memory usage before: 111715.53125 KB . Memory usage after: 110282.875 KB . Inserted 10000 objects in 5.5240259170532 seconds . 100 CmsArticle findAll(): 0.018410 . 100 CmsArticle findAll(): 0.014157 . 100 CmsArticle find(): 0.043304 . 100 CmsArticle find(): 0.041451 . 100 CmsGroup: 0.009315 . 100 CmsGroup: 0.009239 . 100 CmsUser: 0.024051 . 100 CmsUser: 0.023655 . Compute ChangeSet 100 objects in 0.040482997894287 seconds . Time: 19 seconds, Memory: 261.50Mb ``` #### Doctrine Master : ``` . testSimpleQueryScalarHydrationPerformance10000Rows - 0.37668490409851 seconds . testSimpleQueryArrayHydrationPerformance10000Rows - 0.5009880065918 seconds . testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.131824016571 seconds . testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.037791967392 seconds . testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1992859840393 seconds . testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.41158103942871 seconds . testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.86575293540955 seconds . 99 CompanyContract: 0.023206 . 99 CompanyContract: 0.020555 . Inserted 10000 objects in 5.4995818138123 seconds . 100 CmsArticle findAll(): 0.018785 . 100 CmsArticle findAll(): 0.014160 . 100 CmsArticle find(): 0.042067 . 100 CmsArticle find(): 0.041076 . 100 CmsGroup: 0.009478 . 100 CmsGroup: 0.010591 . 100 CmsUser: 0.023727 . 100 CmsUser: 0.023073 . Compute ChangeSet 100 objects in 0.040009021759033 seconds . Time: 19 seconds, Memory: 260.50Mb ```

admin added the pull-request label 2026-01-22 15:58:22 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8096