[PR #354] [MERGED] ValidateSchemaCommand dont't call exit() in execute() #8071

Closed
opened 2026-01-22 15:58:15 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/354
Author: @pscheit
Created: 5/22/2012
Status: Merged
Merged: 5/22/2012
Merged by: @beberlei

Base: masterHead: master


📝 Commits (1)

  • e9f936c don't call exit() in execute()

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php (+1 -1)

📄 Description

calling exit() in the command itself is not needed. Symfony Application calls exit() with the return exit code.

changing this into return makes the validateSchemaCommand usable in other commands as a sub-command


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/354 **Author:** [@pscheit](https://github.com/pscheit) **Created:** 5/22/2012 **Status:** ✅ Merged **Merged:** 5/22/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e9f936c`](https://github.com/doctrine/orm/commit/e9f936c0bae14a5b6e8660b5b5f7cb46cdf2c5f4) don't call exit() in execute() ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php` (+1 -1) </details> ### 📄 Description calling exit() in the command itself is not needed. Symfony Application calls exit() with the return exit code. changing this into return makes the validateSchemaCommand usable in other commands as a sub-command --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:58:15 +01:00
admin closed this issue 2026-01-22 15:58:16 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8071