[PR #347] [CLOSED] Hydrator hotfix - time to think about keeping types for columns #8056

New Issue

admin · 2026-01-22T15:58:11+01:00

admin commented

2026-01-22 15:58:11 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/347
Author: @r0ssIV
Created: 5/5/2012
Status: ❌ Closed

Base: master ← Head: Hydrator_Hotfix_Main

📝 Commits (1)

6fe926f Hydrator hotfix - time to think about keeping types for columns

📊 Changes

1 file changed (+32 additions, -2 deletions)

View changed files

📝 lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php (+32 -2)

📄 Description

Line 251 - nobody cared to call convertToPHPValue($value, $this->_platform);

And I know why - it was hard to determine column type, easier to write $value. :)

... Because type is not in ResultSetMapping

... Because type is not in ClassMetadataInfo either

... Because column types are never considered in associations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/347 **Author:** [@r0ssIV](https://github.com/r0ssIV) **Created:** 5/5/2012 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Hydrator_Hotfix_Main` --- ### 📝 Commits (1) - [`6fe926f`](https://github.com/doctrine/orm/commit/6fe926fcb9298e900a45229d473aaf2c53f6fdc6) Hydrator hotfix - time to think about keeping types for columns ### 📊 Changes **1 file changed** (+32 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php` (+32 -2) </details> ### 📄 Description Line 251 - nobody cared to call convertToPHPValue($value, $this->_platform); And I know why - it was hard to determine column type, easier to write $value. :) ... Because type is not in ResultSetMapping ... Because type is not in ClassMetadataInfo either ... Because column types are never considered in associations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:58:11 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8056