doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #117] [CLOSED] annotation type validation #7730

New Issue
Closed
opened 2026-01-22 15:56:34 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:56:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/117
Author: @FabioBatSilva
Created: 9/4/2011
Status: ❌ Closed

Base: master ← Head: annot-type

📝 Commits (3)

  • 30e9658 adds type validation for annotation mapping
  • 758aae7 Merge remote-tracking branch 'upstream/master' into annot-type
  • df374b8 annotation interface

📊 Changes

12 files changed (+204 additions, -85 deletions)

View changed files

📝 lib/Doctrine/ORM/Mapping/Driver/DoctrineAnnotations.php (+123 -41)
📝 tests/Doctrine/Tests/Models/Company/CompanyCar.php (+1 -1)
📝 tests/Doctrine/Tests/Models/Company/CompanyManager.php (+1 -1)
📝 tests/Doctrine/Tests/Models/ECommerce/ECommerceProduct.php (+1 -1)
📝 tests/Doctrine/Tests/ORM/Functional/QueryCacheTest.php (+35 -14)
📝 tests/Doctrine/Tests/ORM/Functional/ResultCacheTest.php (+24 -8)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC258Test.php (+6 -6)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC522Test.php (+1 -1)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC698Test.php (+3 -3)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC837Test.php (+6 -6)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC992Test.php (+1 -1)
📝 tests/Doctrine/Tests/ORM/Mapping/BasicInheritanceMappingTest.php (+2 -2)

📄 Description

Hello all,

This patch adds the validation types for annotations mapping, that is now supported by the common 2.2.
We have a small incompatibility with tests caused by changes in the common cache.

I'm not familiar with cache package. So I had to use markTestSkipped
Maybe someone can help me with cache tests(QueryCacheTest.php, ResultCacheTest.php)

This feature depends of update to 2.2 common
I think it's a good idea use common 2.2 as default

Thanks ...

Best Regards,
Fabio B. SIlva

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/117 **Author:** [@FabioBatSilva](https://github.com/FabioBatSilva) **Created:** 9/4/2011 **Status:** ❌ Closed **Base:** `master` ← **Head:** `annot-type` --- ### 📝 Commits (3) - [`30e9658`](https://github.com/doctrine/orm/commit/30e96588a2402bd8e48acf86162086458b2a73ac) adds type validation for annotation mapping - [`758aae7`](https://github.com/doctrine/orm/commit/758aae7fb41c3048bfc4adb9d664d4d1e365dc5f) Merge remote-tracking branch 'upstream/master' into annot-type - [`df374b8`](https://github.com/doctrine/orm/commit/df374b83cb78ef944912873089e1c3201aa9f874) annotation interface ### 📊 Changes **12 files changed** (+204 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Mapping/Driver/DoctrineAnnotations.php` (+123 -41) 📝 `tests/Doctrine/Tests/Models/Company/CompanyCar.php` (+1 -1) 📝 `tests/Doctrine/Tests/Models/Company/CompanyManager.php` (+1 -1) 📝 `tests/Doctrine/Tests/Models/ECommerce/ECommerceProduct.php` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Functional/QueryCacheTest.php` (+35 -14) 📝 `tests/Doctrine/Tests/ORM/Functional/ResultCacheTest.php` (+24 -8) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC258Test.php` (+6 -6) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC522Test.php` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC698Test.php` (+3 -3) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC837Test.php` (+6 -6) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC992Test.php` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Mapping/BasicInheritanceMappingTest.php` (+2 -2) </details> ### 📄 Description Hello all, This patch adds the validation types for annotations mapping, that is now supported by the common 2.2. We have a small incompatibility with tests caused by changes in the common cache. I'm not familiar with cache package. So I had to use `markTestSkipped` Maybe someone can help me with cache tests(QueryCacheTest.php, ResultCacheTest.php) This feature depends of update to 2.2 common I think it's a good idea use common 2.2 as default Thanks ... Best Regards, Fabio B. SIlva --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:56:34 +01:00
admin closed this issue 2026-01-22 15:56:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7730
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?