[PR #97] [MERGED] [DDC-1301] Fixed count() for fetch="EXTRA_LAZY" on OneToMany association #7705

Open
opened 2026-01-22 15:56:27 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/97
Author: @asm89
Created: 7/28/2011
Status: Merged
Merged: 7/28/2011
Merged by: @beberlei

Base: masterHead: DDC-1301


📝 Commits (3)

  • b295169 [DDC-1301] Added tests for fetch="EXTRA_LAZY" count() on a "legacy" database
  • d7dbde8 [DDC-1301] Fixed count() for fetch="EXTRA_LAZY" on OneToMany association
  • d439f67 [DDC-1301] Prefixed all Legacy models properties with _

📊 Changes

7 files changed (+388 additions, -7 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/OneToManyPersister.php (+9 -7)
tests/Doctrine/Tests/Models/Legacy/LegacyArticle.php (+33 -0)
tests/Doctrine/Tests/Models/Legacy/LegacyCar.php (+41 -0)
tests/Doctrine/Tests/Models/Legacy/LegacyUser.php (+80 -0)
tests/Doctrine/Tests/Models/Legacy/LegacyUserReference.php (+65 -0)
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1301Test.php (+148 -0)
📝 tests/Doctrine/Tests/OrmFunctionalTestCase.php (+12 -0)

📄 Description

Ticket: http://www.doctrine-project.org/jira/browse/DDC-1301

The first commit adds (failing) tests and a set of "legacy" models. The second commit fixes the issue.

I added the legacy models because it may be useful to use them to verify some other features too? The count() function was broken, but it didn't show up in the tests because all the Cms models that were used for testing map the column id on $id.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/97 **Author:** [@asm89](https://github.com/asm89) **Created:** 7/28/2011 **Status:** ✅ Merged **Merged:** 7/28/2011 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `DDC-1301` --- ### 📝 Commits (3) - [`b295169`](https://github.com/doctrine/orm/commit/b2951691e2c476a2c87212fdf9d0b8deec88d390) [DDC-1301] Added tests for fetch="EXTRA_LAZY" count() on a "legacy" database - [`d7dbde8`](https://github.com/doctrine/orm/commit/d7dbde8f3e2ecbc341e8de47127d0706411bb910) [DDC-1301] Fixed count() for fetch="EXTRA_LAZY" on OneToMany association - [`d439f67`](https://github.com/doctrine/orm/commit/d439f67df5afe43858defbf8e4777afb0fcbb680) [DDC-1301] Prefixed all Legacy models properties with _ ### 📊 Changes **7 files changed** (+388 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/OneToManyPersister.php` (+9 -7) ➕ `tests/Doctrine/Tests/Models/Legacy/LegacyArticle.php` (+33 -0) ➕ `tests/Doctrine/Tests/Models/Legacy/LegacyCar.php` (+41 -0) ➕ `tests/Doctrine/Tests/Models/Legacy/LegacyUser.php` (+80 -0) ➕ `tests/Doctrine/Tests/Models/Legacy/LegacyUserReference.php` (+65 -0) ➕ `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1301Test.php` (+148 -0) 📝 `tests/Doctrine/Tests/OrmFunctionalTestCase.php` (+12 -0) </details> ### 📄 Description Ticket: http://www.doctrine-project.org/jira/browse/DDC-1301 The first commit adds (failing) tests and a set of "legacy" models. The second commit fixes the issue. I added the legacy models because it may be useful to use them to verify some other features too? The count() function was broken, but it didn't show up in the tests because all the Cms models that were used for testing map the column `id` on $id. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:56:27 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7705