[PR #88] [MERGED] [DDC-1294] Add discriminator information to subselects #7697

New Issue

admin · 2026-01-22T15:56:25+01:00

admin commented

2026-01-22 15:56:25 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/88
Author: @asm89
Created: 7/25/2011
Status: ✅ Merged
Merged: 7/26/2011
Merged by: @guilhermeblanco

Base: master ← Head: DDC-1294

📝 Commits (2)

65f7e89 [DDC-1294] Add discriminator information to subselects
97a4dbf [DDC-1294] Added more tests for subselects in subselects

📊 Changes

2 files changed (+62 additions, -22 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/SqlWalker.php (+19 -22)
📝 tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php (+43 -0)

📄 Description

Fixes: http://www.doctrine-project.org/jira/browse/DDC-1294.

The testsuite runs + a new testcase for the bug.

I also refactored the walking of the where clause to one function to reduce copy-paste code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/88 **Author:** [@asm89](https://github.com/asm89) **Created:** 7/25/2011 **Status:** ✅ Merged **Merged:** 7/26/2011 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `DDC-1294` --- ### 📝 Commits (2) - [`65f7e89`](https://github.com/doctrine/orm/commit/65f7e897b579549b9ef75465edcad4d32d54f727) [DDC-1294] Add discriminator information to subselects - [`97a4dbf`](https://github.com/doctrine/orm/commit/97a4dbf2cd7d199af8a96eb5240eb5e94a022337) [DDC-1294] Added more tests for subselects in subselects ### 📊 Changes **2 files changed** (+62 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+19 -22) 📝 `tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php` (+43 -0) </details> ### 📄 Description Fixes: http://www.doctrine-project.org/jira/browse/DDC-1294. The testsuite runs + a new testcase for the bug. I also refactored the walking of the where clause to one function to reduce copy-paste code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:56:25 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7697