mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
[PR #65] [MERGED] [Tools][Console] Refactoring the UpdateCommand #7664
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/doctrine/orm/pull/65
Author: @weaverryan
Created: 6/3/2011
Status: ✅ Merged
Merged: 6/11/2011
Merged by: @beberlei
Base:
master← Head:update_command📝 Commits (2)
79643e3[Tools][Console] Refactoring the UpdateCommand6468740[Tools][Console] Reworking changes to be more backwards compatible📊 Changes
1 file changed (+60 additions, -28 deletions)
View changed files
📝
lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php(+60 -28)���� Description
There are two basic changes:
Changed --force and --dump-sql from options to a single argument. Prior, you couldn't pass both options simultaneously anyways, so making them an argument is more accurate. This confused a user this morning, who was passing both options and expecting it to dump and execute.
Changed the language and formatting of the task to be more user-friendly.
Also, I've taken advantage of the
getFullName()method anywhere when outputting help information on command usage so that the information will still be accurate when the task is subclassed and its name changed (e.g. like in a Symfony integration).Thanks!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.