[PR #65] [MERGED] [Tools][Console] Refactoring the UpdateCommand #7664

Closed
opened 2026-01-22 15:56:14 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/65
Author: @weaverryan
Created: 6/3/2011
Status: Merged
Merged: 6/11/2011
Merged by: @beberlei

Base: masterHead: update_command


📝 Commits (2)

  • 79643e3 [Tools][Console] Refactoring the UpdateCommand
  • 6468740 [Tools][Console] Reworking changes to be more backwards compatible

📊 Changes

1 file changed (+60 additions, -28 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php (+60 -28)

���� Description

There are two basic changes:

  1. Changed --force and --dump-sql from options to a single argument. Prior, you couldn't pass both options simultaneously anyways, so making them an argument is more accurate. This confused a user this morning, who was passing both options and expecting it to dump and execute.

  2. Changed the language and formatting of the task to be more user-friendly.

Also, I've taken advantage of the getFullName() method anywhere when outputting help information on command usage so that the information will still be accurate when the task is subclassed and its name changed (e.g. like in a Symfony integration).

Thanks!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/65 **Author:** [@weaverryan](https://github.com/weaverryan) **Created:** 6/3/2011 **Status:** ✅ Merged **Merged:** 6/11/2011 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `update_command` --- ### 📝 Commits (2) - [`79643e3`](https://github.com/doctrine/orm/commit/79643e32ed3f3a6679428b5d6dc152e70fed5c13) [Tools][Console] Refactoring the UpdateCommand - [`6468740`](https://github.com/doctrine/orm/commit/64687409155f5e547b2611db1eed4948fba847f9) [Tools][Console] Reworking changes to be more backwards compatible ### 📊 Changes **1 file changed** (+60 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php` (+60 -28) </details> ### ���� Description There are two basic changes: 1) Changed --force and --dump-sql from options to a single argument. Prior, you couldn't pass both options simultaneously anyways, so making them an argument is more accurate. This confused a user this morning, who was passing both options and expecting it to dump _and_ execute. 2) Changed the language and formatting of the task to be more user-friendly. Also, I've taken advantage of the `getFullName()` method anywhere when outputting help information on command usage so that the information will still be accurate when the task is subclassed and its name changed (e.g. like in a Symfony integration). Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:56:14 +01:00
admin closed this issue 2026-01-22 15:56:15 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7664