[PR #52] [CLOSED] Cannot do findBy lookup by 'field' => null anymore #7639

New Issue

admin · 2026-01-22T15:56:07+01:00

admin commented

2026-01-22 15:56:07 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/52
Author: @dbtlr
Created: 5/6/2011
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (3)

6d98121 This block of code was added in 2.0.4 and removes the ability to perform a findBy(array('field' => NULL)); in order to find all records where that field is null. The commit it was attached to appears to be for a different problem and this appears to have been added in by mistake. This solution not only causes a new problem, but did not solve the original problem. There is an associated unit test that needs to be removed as well.
5bbd7c0 This was a bad unit test that was verifying that bad logic was TRUE.
21e53cf Merge branch 'patch-2' into patch-1

📊 Changes

2 files changed (+0 additions, -17 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+0 -4)
📝 tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php (+0 -13)

📄 Description

This block of code was added in 2.0.4 and removes the ability to perform a findBy(array('field' => NULL)); in order to find all records where that field is null. The commit it was attached to appears to be for a different problem and this appears to have been added in by mistake. This solution not only causes a new problem, but did not solve the original problem. There is an associated unit test that needs to be removed as well.

Problem commit: af5bcc148d
The original commit message: [DDC-1087] Add missing resolution to IS NULL in EntityRepository when passing a null value as a criteria.

This commit did in fact add the code to fix the original problem but then added another block of code to make it just not work at all.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/52 **Author:** [@dbtlr](https://github.com/dbtlr) **Created:** 5/6/2011 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`6d98121`](https://github.com/doctrine/orm/commit/6d9812149a6c041ef0efce4bb40e7f2fb5d6ed90) This block of code was added in 2.0.4 and removes the ability to perform a findBy(array('field' => NULL)); in order to find all records where that field is null. The commit it was attached to appears to be for a different problem and this appears to have been added in by mistake. This solution not only causes a new problem, but did not solve the original problem. There is an associated unit test that needs to be removed as well. - [`5bbd7c0`](https://github.com/doctrine/orm/commit/5bbd7c0264d206d43de2c744013696dfe444f22a) This was a bad unit test that was verifying that bad logic was TRUE. - [`21e53cf`](https://github.com/doctrine/orm/commit/21e53cf1bf5c0e32e7d762f91db6683ffb2868e3) Merge branch 'patch-2' into patch-1 ### 📊 Changes **2 files changed** (+0 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+0 -4) 📝 `tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php` (+0 -13) </details> ### 📄 Description This block of code was added in 2.0.4 and removes the ability to perform a findBy(array('field' => NULL)); in order to find all records where that field is null. The commit it was attached to appears to be for a different problem and this appears to have been added in by mistake. This solution not only causes a new problem, but did not solve the original problem. There is an associated unit test that needs to be removed as well. Problem commit: af5bcc148d7460de2843 The original commit message: [DDC-1087] Add missing resolution to IS NULL in EntityRepository when passing a null value as a criteria. This commit did in fact add the code to fix the original problem but then added another block of code to make it just not work at all. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:56:07 +01:00

admin closed this issue

2026-01-22 15:56:08 +01:00

admin referenced this issue

2026-01-22 16:08:01 +01:00

[PR #7639] Fixed break/continue error with PHP7.3 #10576

Sign in to join this conversation.