[PR #43] [CLOSED] Fixed Parser::match not matching token value (only type) #7633

New Issue

admin · 2026-01-22T15:56:05+01:00

admin commented

2026-01-22 15:56:05 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/43
Author: @Chekote
Created: 4/1/2011
Status: ❌ Closed

Base: master ← Head: parser_match_value

📝 Commits (1)

2cf36d8 Fixed Parser::match not matching token value (only type)

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/Parser.php (+2 -1)

📄 Description

According to the phpdoc for Parser::match(), the token provided can be either the token type or value. However, the method only checked type.

The method is now in accordance with the phpdoc.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/43 **Author:** [@Chekote](https://github.com/Chekote) **Created:** 4/1/2011 **Status:** ❌ Closed **Base:** `master` ← **Head:** `parser_match_value` --- ### 📝 Commits (1) - [`2cf36d8`](https://github.com/doctrine/orm/commit/2cf36d8bdf41a303d9b574be3319a4ae62b2d4a3) Fixed Parser::match not matching token value (only type) ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/Parser.php` (+2 -1) </details> ### 📄 Description According to the phpdoc for Parser::match(), the token provided can be either the token type or value. However, the method only checked type. The method is now in accordance with the phpdoc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:56:05 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7633