Significant performance degradation with enable_lazy_ghost_objects: true #7261

@michnovka commented on GitHub (Feb 12, 2024):

Has anybody else managed to reproduce this issue?

@michnovka commented on GitHub (Feb 12, 2024): Has anybody else managed to reproduce this issue?

admin commented

@marforon commented on GitHub (Feb 21, 2024):

Yes, it's drawn back for us to upgrade; this represents a significant performance degradation.

@marforon commented on GitHub (Feb 21, 2024): Yes, it's drawn back for us to upgrade; this represents a significant performance degradation.

admin commented

@rrehbein commented on GitHub (Feb 21, 2024):

Starting from the reproduction instructions javar left of:

git clone https://github.com/javer/doctrine-orm-lazy-ghost
cd doctrine-orm-lazy-ghost
composer install
bin/console app:test:orm

Run on an AWS EC2 AL2023 c5.large with php version:

PHP 8.2.15 (cli) (built: Jan 16 2024 12:19:32) (NTS gcc x86_64)
Copyright (c) The PHP Group
Zend Engine v4.2.15, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.15, Copyright (c), by Zend Technologies

Results:

test	lazy: true	lazy: false	note
sample code run as-is	7.194498	2.752580
... after composer update	7.263963	2.794993
... after upgrade to SF6.4	7.284943	2.840720	This didn't change ORM version, so not really relevant
... after upgrade to ORM v3	6.807350	n/a
TestOrmCommand added to another project	7.287983	2.722694	a blended SF5.4/6.4 mid-upgrade

Reproduction code after SF6.4 update:

$ composer show 'doctrine/*' | awk '{print $1 " " $2}' | column -t

doctrine/cache                       2.2.0
doctrine/collections                 2.1.4
doctrine/common                      3.4.3
doctrine/dbal                        3.8.2
doctrine/deprecations                1.1.3
doctrine/doctrine-bundle             2.11.3
doctrine/doctrine-migrations-bundle  3.3.0
doctrine/event-manager               2.0.0
doctrine/inflector                   2.0.10
doctrine/instantiator                2.0.0
doctrine/lexer                       3.0.1
doctrine/migrations                  3.7.2
doctrine/orm                         2.18.0
doctrine/persistence                 3.2.0
doctrine/sql-formatter               1.1.3

Reproduction code after ORM v3 upgrade:

$ composer show 'doctrine/*' | awk '{print $1 " " $2}' | column -t

doctrine/cache                       2.2.0
doctrine/collections                 2.1.4
doctrine/dbal                        4.0.0
doctrine/deprecations                1.1.3
doctrine/doctrine-bundle             2.11.3
doctrine/doctrine-migrations-bundle  3.3.0
doctrine/event-manager               2.0.0
doctrine/inflector                   2.0.10
doctrine/instantiator                2.0.0
doctrine/lexer                       3.0.1
doctrine/migrations                  3.7.2
doctrine/orm                         3.0.0
doctrine/persistence                 3.2.0
doctrine/sql-formatter               1.1.3

Other project:

$ composer show 'doctrine/*' | awk '{print $1 " " $2}' | column -t

doctrine/annotations               2.0.1
doctrine/cache                     2.2.0
doctrine/collections               2.1.4
doctrine/common                    3.4.3
doctrine/data-fixtures             1.7.0
doctrine/dbal                      3.8.0
doctrine/deprecations              1.1.2
doctrine/doctrine-bundle           2.11.1
doctrine/doctrine-fixtures-bundle  3.5.1
doctrine/event-manager             1.2.0
doctrine/inflector                 2.0.9
doctrine/instantiator              1.5.0
doctrine/lexer                     2.1.0
doctrine/orm                       2.17.4
doctrine/persistence               3.2.0
doctrine/sql-formatter             1.1.3

@rrehbein commented on GitHub (Feb 21, 2024): Starting from the reproduction instructions javar left of: ``` git clone https://github.com/javer/doctrine-orm-lazy-ghost cd doctrine-orm-lazy-ghost composer install bin/console app:test:orm ``` Run on an AWS EC2 AL2023 c5.large with php version: ``` PHP 8.2.15 (cli) (built: Jan 16 2024 12:19:32) (NTS gcc x86_64) Copyright (c) The PHP Group Zend Engine v4.2.15, Copyright (c) Zend Technologies with Zend OPcache v8.2.15, Copyright (c), by Zend Technologies ``` Results: | test | lazy: true | lazy: false | note | | :--- | ---: | ---: | :--- | | sample code run as-is | 7.194498 | 2.752580 | | | ... after composer update | 7.263963 | 2.794993 | | | ... after upgrade to SF6.4 | 7.284943 | 2.840720 | This didn't change ORM version, so not really relevant | | ... after upgrade to ORM v3 | 6.807350 | n/a | | | TestOrmCommand added to another project | 7.287983 | 2.722694 | a blended SF5.4/6.4 mid-upgrade | Reproduction code after SF6.4 update: ``` $ composer show 'doctrine/*' | awk '{print $1 " " $2}' | column -t doctrine/cache 2.2.0 doctrine/collections 2.1.4 doctrine/common 3.4.3 doctrine/dbal 3.8.2 doctrine/deprecations 1.1.3 doctrine/doctrine-bundle 2.11.3 doctrine/doctrine-migrations-bundle 3.3.0 doctrine/event-manager 2.0.0 doctrine/inflector 2.0.10 doctrine/instantiator 2.0.0 doctrine/lexer 3.0.1 doctrine/migrations 3.7.2 doctrine/orm 2.18.0 doctrine/persistence 3.2.0 doctrine/sql-formatter 1.1.3 ``` Reproduction code after ORM v3 upgrade: ``` $ composer show 'doctrine/*' | awk '{print $1 " " $2}' | column -t doctrine/cache 2.2.0 doctrine/collections 2.1.4 doctrine/dbal 4.0.0 doctrine/deprecations 1.1.3 doctrine/doctrine-bundle 2.11.3 doctrine/doctrine-migrations-bundle 3.3.0 doctrine/event-manager 2.0.0 doctrine/inflector 2.0.10 doctrine/instantiator 2.0.0 doctrine/lexer 3.0.1 doctrine/migrations 3.7.2 doctrine/orm 3.0.0 doctrine/persistence 3.2.0 doctrine/sql-formatter 1.1.3 ``` Other project: ``` $ composer show 'doctrine/*' | awk '{print $1 " " $2}' | column -t doctrine/annotations 2.0.1 doctrine/cache 2.2.0 doctrine/collections 2.1.4 doctrine/common 3.4.3 doctrine/data-fixtures 1.7.0 doctrine/dbal 3.8.0 doctrine/deprecations 1.1.2 doctrine/doctrine-bundle 2.11.1 doctrine/doctrine-fixtures-bundle 3.5.1 doctrine/event-manager 1.2.0 doctrine/inflector 2.0.9 doctrine/instantiator 1.5.0 doctrine/lexer 2.1.0 doctrine/orm 2.17.4 doctrine/persistence 3.2.0 doctrine/sql-formatter 1.1.3 ```

admin commented

@beberlei commented on GitHub (Feb 22, 2024):

Here is a screenshot of a compare callgraph in Tideways Profiler, it shows the relevant parts that are slow:

createLazyGhost static factory
The callback returned from ProxyFactory::getProxyFactory

The overall slowdown is roughly in line what @rrehbein reported.

I will take a deeper look when i have more time.

@beberlei commented on GitHub (Feb 22, 2024): Here is a screenshot of a compare callgraph in Tideways Profiler, it shows the relevant parts that are slow: * createLazyGhost static factory * The callback returned from ProxyFactory::getProxyFactory The overall slowdown is roughly in line what @rrehbein reported. ![Bildschirmfoto 2024-02-22 um 13 47 25](https://github.com/doctrine/orm/assets/26936/1e1127ae-0b3f-4d90-8c4d-01d1d29cccb0) I will take a deeper look when i have more time.

admin commented

@beberlei commented on GitHub (Feb 25, 2024):

I looked at createLazyGhost factory method and found that it acts both as an initializer when invoked the first time, and then as a factory for lazy ghosts. It seems when the initializer code is run every time as well, this causes a lot of wasted CPU and allocated memory. A simple attempt to split both methods up cut 50% of the slowdown:

I hardcoded it into my doctrine/orm and symfony/var_exporter components of @javer testproject. So no nice diff, the changed lines are here: https://gist.github.com/beberlei/97899ea7ce4261502a6df1300ab9f181

This would require var-exporter to add these new methods, so I am looking to find a simpler fix that cuts the time and memory in createLazyGhost already.

@beberlei commented on GitHub (Feb 25, 2024): I looked at createLazyGhost factory method and found that it acts both as an initializer when invoked the first time, and then as a factory for lazy ghosts. It seems when the initializer code is run every time as well, this causes a lot of wasted CPU and allocated memory. A simple attempt to split both methods up cut 50% of the slowdown: <img width="570" alt="Bildschirmfoto 2024-02-25 um 12 11 42" src="https://github.com/doctrine/orm/assets/26936/7ae5daeb-fd49-407d-aba1-9f50ac1b4720"> I hardcoded it into my doctrine/orm and symfony/var_exporter components of @javer testproject. So no nice diff, the changed lines are here: https://gist.github.com/beberlei/97899ea7ce4261502a6df1300ab9f181 This would require var-exporter to add these new methods, so I am looking to find a simpler fix that cuts the time and memory in createLazyGhost already.

admin commented

@nicolas-grekas commented on GitHub (Mar 9, 2024):

This patch saves a lot of time by not creating a closure in a loop. Note that this change breaks tests so it's not the correct one but that might give some ideas :

--- a/src/Proxy/ProxyFactory.php
+++ b/src/Proxy/ProxyFactory.php
@@ -466,18 +466,15 @@ EOPHP;
         $initializer      = $this->createLazyInitializer($class, $entityPersister, $this->identifierFlattener);
         $proxyClassName   = $this->loadProxyClass($class);
         $identifierFields = array_intersect_key($class->getReflectionProperties(), $identifiers);
+        $initializer = static function (InternalProxy $object) use ($initializer): void {
+            $initializer($object, $object);
+        };
 
         $proxyFactory = Closure::bind(static function (array $identifier) use ($initializer, $skippedProperties, $identifierFields, $className): InternalProxy {
-            $proxy = self::createLazyGhost(static function (InternalProxy $object) use ($initializer, &$proxy): void {
-                $initializer($object, $proxy);
-            }, $skippedProperties);
+            $proxy = self::createLazyGhost($initializer, $skippedProperties);
 
             foreach ($identifierFields as $idField => $reflector) {
-                if (! isset($identifier[$idField])) {
-                    throw ORMInvalidArgumentException::missingPrimaryKeyValue($className, $idField);
-                }
-
-                $reflector->setValue($proxy, $identifier[$idField]);
+                $reflector->setValue($proxy, $identifier[$idField] ?? throw ORMInvalidArgumentException::missingPrimaryKeyValue($className, $idField));
             }
 
             return $proxy;

@nicolas-grekas commented on GitHub (Mar 9, 2024): This patch saves a lot of time by not creating a closure in a loop. Note that this change breaks tests so it's not the correct one but that might give some ideas : ```diff --- a/src/Proxy/ProxyFactory.php +++ b/src/Proxy/ProxyFactory.php @@ -466,18 +466,15 @@ EOPHP; $initializer = $this->createLazyInitializer($class, $entityPersister, $this->identifierFlattener); $proxyClassName = $this->loadProxyClass($class); $identifierFields = array_intersect_key($class->getReflectionProperties(), $identifiers); + $initializer = static function (InternalProxy $object) use ($initializer): void { + $initializer($object, $object); + }; $proxyFactory = Closure::bind(static function (array $identifier) use ($initializer, $skippedProperties, $identifierFields, $className): InternalProxy { - $proxy = self::createLazyGhost(static function (InternalProxy $object) use ($initializer, &$proxy): void { - $initializer($object, $proxy); - }, $skippedProperties); + $proxy = self::createLazyGhost($initializer, $skippedProperties); foreach ($identifierFields as $idField => $reflector) { - if (! isset($identifier[$idField])) { - throw ORMInvalidArgumentException::missingPrimaryKeyValue($className, $idField); - } - - $reflector->setValue($proxy, $identifier[$idField]); + $reflector->setValue($proxy, $identifier[$idField] ?? throw ORMInvalidArgumentException::missingPrimaryKeyValue($className, $idField)); } return $proxy; ```

admin commented

@nicolas-grekas commented on GitHub (Mar 9, 2024):

@beberlei don't mind sharing a reproducer with vendor/ committed and I might be able dig your ideas also.

@nicolas-grekas commented on GitHub (Mar 9, 2024): @beberlei don't mind sharing a reproducer with vendor/ committed and I might be able dig your ideas also.

admin commented

@nicolas-grekas commented on GitHub (Mar 9, 2024):

IIUC, most of your gain @beberlei can be achieved by this patch, isn't it?

--- a/src/Symfony/Component/VarExporter/LazyGhostTrait.php
+++ b/src/Symfony/Component/VarExporter/LazyGhostTrait.php
@@ -35,15 +35,24 @@ trait LazyGhostTrait
     {
         if (self::class !== $class = $instance ? $instance::class : static::class) {
             $skippedProperties["\0".self::class."\0lazyObjectState"] = true;
-        } elseif (\defined($class.'::LAZY_OBJECT_PROPERTY_SCOPES')) {
-            Hydrator::$propertyScopes[$class] ??= $class::LAZY_OBJECT_PROPERTY_SCOPES;
         }
 
-        $instance ??= (Registry::$classReflectors[$class] ??= new \ReflectionClass($class))->newInstanceWithoutConstructor();
-        Registry::$defaultProperties[$class] ??= (array) $instance;
+        if (!isset(Registry::$defaultProperties[$class])) {
+            Registry::$classReflectors[$class] ??= new \ReflectionClass($class);
+            $instance ??= Registry::$classReflectors[$class]->newInstanceWithoutConstructor();
+            Registry::$defaultProperties[$class] ??= (array) $instance;
+            Registry::$classResetters[$class] ??= Registry::getClassResetters($class);
+
+            if (self::class === $class && \defined($class.'::LAZY_OBJECT_PROPERTY_SCOPES')) {
+                Hydrator::$propertyScopes[$class] ??= $class::LAZY_OBJECT_PROPERTY_SCOPES;
+            }
+        } else {
+            $instance ??= Registry::$classReflectors[$class]->newInstanceWithoutConstructor();
+        }
+
         $instance->lazyObjectState = new LazyObjectState($initializer, $skippedProperties ??= []);
 
-        foreach (Registry::$classResetters[$class] ??= Registry::getClassResetters($class) as $reset) {
+        foreach (Registry::$classResetters[$class] as $reset) {
             $reset($instance, $skippedProperties);
         }

@nicolas-grekas commented on GitHub (Mar 9, 2024): IIUC, most of your gain @beberlei can be achieved by this patch, isn't it? ```diff --- a/src/Symfony/Component/VarExporter/LazyGhostTrait.php +++ b/src/Symfony/Component/VarExporter/LazyGhostTrait.php @@ -35,15 +35,24 @@ trait LazyGhostTrait { if (self::class !== $class = $instance ? $instance::class : static::class) { $skippedProperties["\0".self::class."\0lazyObjectState"] = true; - } elseif (\defined($class.'::LAZY_OBJECT_PROPERTY_SCOPES')) { - Hydrator::$propertyScopes[$class] ??= $class::LAZY_OBJECT_PROPERTY_SCOPES; } - $instance ??= (Registry::$classReflectors[$class] ??= new \ReflectionClass($class))->newInstanceWithoutConstructor(); - Registry::$defaultProperties[$class] ??= (array) $instance; + if (!isset(Registry::$defaultProperties[$class])) { + Registry::$classReflectors[$class] ??= new \ReflectionClass($class); + $instance ??= Registry::$classReflectors[$class]->newInstanceWithoutConstructor(); + Registry::$defaultProperties[$class] ??= (array) $instance; + Registry::$classResetters[$class] ??= Registry::getClassResetters($class); + + if (self::class === $class && \defined($class.'::LAZY_OBJECT_PROPERTY_SCOPES')) { + Hydrator::$propertyScopes[$class] ??= $class::LAZY_OBJECT_PROPERTY_SCOPES; + } + } else { + $instance ??= Registry::$classReflectors[$class]->newInstanceWithoutConstructor(); + } + $instance->lazyObjectState = new LazyObjectState($initializer, $skippedProperties ??= []); - foreach (Registry::$classResetters[$class] ??= Registry::getClassResetters($class) as $reset) { + foreach (Registry::$classResetters[$class] as $reset) { $reset($instance, $skippedProperties); } ```

admin commented

@nicolas-grekas commented on GitHub (Mar 13, 2024):

Below is a better patch for the ORM side. Together with this one https://github.com/symfony/symfony/pull/54253, I get the following stats on my machine:

lazy-ghosts disabled: 2.94 s
lazy-ghosts patched: 4.02 s
lazy-ghosts unpatched: 7.83 s

Locally, I also have a native proxy implementation for php-src (I need to write an RFC about it), and with it, I get 3.27s with the current API and implementation. That's good food for thoughts on my side to move this RFC forward :)

Here is the Blackfire.io comparison between disabled and patched lazy-ghosts:
https://blackfire.io/profiles/compare/4561cec4-97af-4c40-a180-ee5745ca8119/graph

The patch for ProxyFactory.php

--- a/src/Proxy/ProxyFactory.php
+++ b/src/Proxy/ProxyFactory.php
@@ -360,11 +360,11 @@ EOPHP;
      */
     private function createLazyInitializer(ClassMetadata $classMetadata, EntityPersister $entityPersister, IdentifierFlattener $identifierFlattener): Closure
     {
-        return static function (InternalProxy $proxy, InternalProxy $original) use ($entityPersister, $classMetadata, $identifierFlattener): void {
-            $identifier = $classMetadata->getIdentifierValues($original);
-            $entity     = $entityPersister->loadById($identifier, $original);
+        return static function (InternalProxy $proxy) use ($entityPersister, $classMetadata, $identifierFlattener): void {
+            $identifier = $classMetadata->getIdentifierValues($proxy);
+            $original   = $entityPersister->loadById($identifier);
 
-            if ($entity === null) {
+            if ($original === null) {
                 throw EntityNotFoundException::fromClassNameAndIdentifier(
                     $classMetadata->getName(),
                     $identifierFlattener->flattenIdentifier($classMetadata, $identifier)
@@ -382,7 +382,7 @@ EOPHP;
                     continue;
                 }
 
-                $property->setValue($proxy, $property->getValue($entity));
+                $property->setValue($proxy, $property->getValue($original));
             }
         };
     }
@@ -468,9 +468,7 @@ EOPHP;
         $identifierFields = array_intersect_key($class->getReflectionProperties(), $identifiers);
 
         $proxyFactory = Closure::bind(static function (array $identifier) use ($initializer, $skippedProperties, $identifierFields, $className): InternalProxy {
-            $proxy = self::createLazyGhost(static function (InternalProxy $object) use ($initializer, &$proxy): void {
-                $initializer($object, $proxy);
-            }, $skippedProperties);
+            $proxy = self::createLazyGhost($initializer, $skippedProperties);
 
             foreach ($identifierFields as $idField => $reflector) {
                 if (! isset($identifier[$idField])) {

@nicolas-grekas commented on GitHub (Mar 13, 2024): Below is a better patch for the ORM side. Together with this one https://github.com/symfony/symfony/pull/54253, I get the following stats on my machine: - lazy-ghosts disabled: 2.94 s - lazy-ghosts patched: 4.02 s - lazy-ghosts unpatched: 7.83 s Locally, I also have a native proxy implementation for php-src (I need to write an RFC about it), and with it, I get 3.27s with the current API and implementation. That's good food for thoughts on my side to move this RFC forward :) Here is the Blackfire.io comparison between disabled and patched lazy-ghosts: https://blackfire.io/profiles/compare/4561cec4-97af-4c40-a180-ee5745ca8119/graph ![image](https://github.com/doctrine/orm/assets/243674/c79910d7-84bc-4a49-ba6a-f7d1b59c9e5b) <details> <summary>The patch for ProxyFactory.php</summary> ```diff --- a/src/Proxy/ProxyFactory.php +++ b/src/Proxy/ProxyFactory.php @@ -360,11 +360,11 @@ EOPHP; */ private function createLazyInitializer(ClassMetadata $classMetadata, EntityPersister $entityPersister, IdentifierFlattener $identifierFlattener): Closure { - return static function (InternalProxy $proxy, InternalProxy $original) use ($entityPersister, $classMetadata, $identifierFlattener): void { - $identifier = $classMetadata->getIdentifierValues($original); - $entity = $entityPersister->loadById($identifier, $original); + return static function (InternalProxy $proxy) use ($entityPersister, $classMetadata, $identifierFlattener): void { + $identifier = $classMetadata->getIdentifierValues($proxy); + $original = $entityPersister->loadById($identifier); - if ($entity === null) { + if ($original === null) { throw EntityNotFoundException::fromClassNameAndIdentifier( $classMetadata->getName(), $identifierFlattener->flattenIdentifier($classMetadata, $identifier) @@ -382,7 +382,7 @@ EOPHP; continue; } - $property->setValue($proxy, $property->getValue($entity)); + $property->setValue($proxy, $property->getValue($original)); } }; } @@ -468,9 +468,7 @@ EOPHP; $identifierFields = array_intersect_key($class->getReflectionProperties(), $identifiers); $proxyFactory = Closure::bind(static function (array $identifier) use ($initializer, $skippedProperties, $identifierFields, $className): InternalProxy { - $proxy = self::createLazyGhost(static function (InternalProxy $object) use ($initializer, &$proxy): void { - $initializer($object, $proxy); - }, $skippedProperties); + $proxy = self::createLazyGhost($initializer, $skippedProperties); foreach ($identifierFields as $idField => $reflector) { if (! isset($identifier[$idField])) { ``` </details>

admin commented

2026-01-22 15:48:28 +01:00

@michnovka commented on GitHub (Mar 13, 2024):

Is the goal to get to the same or better performance than with lazyghosts disabled or is this considered "good enough" result?

@michnovka commented on GitHub (Mar 13, 2024): Is the goal to get to the same or better performance than with lazyghosts disabled or is this considered "good enough" result?

admin commented

@nicolas-grekas commented on GitHub (Mar 13, 2024):

This is good enough to me. The core issue with the current code is the initializer closure that creates a self-reference in the object graph, which adds a lot of pressure on the garbage collector. The other changes are minor perf optim that shouldn't matter much in practice.
Note that we're comparing two widely different set of proxies. The legacy proxy system has many serious limitations.

@nicolas-grekas commented on GitHub (Mar 13, 2024): This is good enough to me. The core issue with the current code is the initializer closure that creates a self-reference in the object graph, which adds a lot of pressure on the garbage collector. The other changes are minor perf optim that shouldn't matter much in practice. Note that we're comparing two widely different set of proxies. The legacy proxy system has many serious limitations.

admin commented

2026-01-22 15:48:28 +01:00

@beberlei commented on GitHub (Mar 13, 2024):

@nicolas-grekas does your change here require the symfony change or are they independent?

The improvement is good enough for me too for now.

@beberlei commented on GitHub (Mar 13, 2024): @nicolas-grekas does your change here require the symfony change or are they independent? The improvement is good enough for me too for now.

admin commented

@nicolas-grekas commented on GitHub (Mar 14, 2024):

The patch are independent. BUT the ORM patch makes the test suite fail on one or two test cases which we need to investigate.

@nicolas-grekas commented on GitHub (Mar 14, 2024): The patch are independent. BUT the ORM patch makes the test suite fail on one or two test cases which we need to investigate.

admin commented

@Tristan971 commented on GitHub (Mar 22, 2024):

This is good enough to me. [...] The legacy proxy system has many serious limitations.

I don't doubt that the new setup is better, and I'm sure eventually it will catch up, but right now we're seeing the same results as you outline in https://github.com/doctrine/orm/issues/11087#issuecomment-1994002826, so losing half the performance (from 17s to 29s for setting up a subset of test fixtures).

That's many times better than before your patch, of course, but still a fairly high cost... I hope the issue keeps getting some attention until we're in a closer performance range.

EDIT: turns out I was comparing on 2.19.2 which lacks the patch; using 2.19.3 seems to fix the issue entirely for our use-case (at least with synthetic loads, we'll have to compare for real load).

@Tristan971 commented on GitHub (Mar 22, 2024): > This is good enough to me. [...] The legacy proxy system has many serious limitations. I don't doubt that the new setup is better, and I'm sure eventually it will catch up, but right now we're seeing the same results as you outline in https://github.com/doctrine/orm/issues/11087#issuecomment-1994002826, so losing half the performance (from 17s to 29s for setting up a subset of test fixtures). That's many times better than before your patch, of course, but still a fairly high cost... I hope the issue keeps getting some attention until we're in a closer performance range. EDIT: turns out I was comparing on 2.19.2 which lacks the patch; using 2.19.3 seems to fix the issue entirely for our use-case (at least with synthetic loads, we'll have to compare for real load).

admin commented

@nicolas-grekas commented on GitHub (Mar 23, 2024):

EDIT: turns out I was comparing on 2.19.2 which lacks the patch; using 2.19.3 seems to fix the issue entirely for our use-case (at least with synthetic loads, we'll have to compare for real load).

Good news!

We can close this issue then :)

@nicolas-grekas commented on GitHub (Mar 23, 2024): > EDIT: turns out I was comparing on 2.19.2 which lacks the patch; using 2.19.3 seems to fix the issue entirely for our use-case (at least with synthetic loads, we'll have to compare for real load). Good news! We can close this issue then :)

admin commented

@greg0ire commented on GitHub (Mar 23, 2024):

Let's! Thanks @nicolas-grekas !

@greg0ire commented on GitHub (Mar 23, 2024): Let's! Thanks @nicolas-grekas !

admin commented

@Tristan971 commented on GitHub (Mar 23, 2024):

turns out I was comparing on 2.19.2 which lacks the patch; using 2.19.3 seems to fix the issue entirely for our use-case (at least with synthetic loads, we'll have to compare for real load).

For what it's worth, we also see no performance difference at all after deploying to our production:

So I can only agree with the decision to close it 👍

@Tristan971 commented on GitHub (Mar 23, 2024): > turns out I was comparing on 2.19.2 which lacks the patch; using 2.19.3 seems to fix the issue entirely for our use-case (at least with synthetic loads, we'll have to compare for real load). For what it's worth, we also see no performance difference at all after deploying to our production: ![image](https://github.com/doctrine/orm/assets/875533/885ef924-d8ca-45de-8037-e1bf72acfc85) So I can only agree with the decision to close it :+1:

admin commented