2.15.1 generated warnings in AttributeDriver::joinColumnToArray() #7147

New Issue

Closed

opened 2026-01-22 15:45:33 +01:00 by admin · 9 comments

admin commented 2026-01-22 15:45:33 +01:00

Owner

Copy Link

Originally created by @verfriemelt-dot-org on GitHub (May 8, 2023).

BC Break Report

Q	A
BC Break	yes
Version	2.15.1 (no warnings in 2.15.0)

Summary

this change: https://github.com/doctrine/orm/pull/10671/files#diff-c058a8444ffba22cecd48a76b9577187ef8eba003369d9b8d94313b4325d1b76
results in warnings due to seemling a wrong data type beeing passed?

Warning: Attempt to read property "name" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 694
Warning: Attempt to read property "unique" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 695
Warning: Attempt to read property "nullable" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 696
Warning: Attempt to read property "onDelete" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 697
Warning: Attempt to read property "columnDefinition" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 698
Warning: Attempt to read property "referencedColumnName" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 699
Warning: Attempt to read property "options" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 702

Previous behavior

no warnings

Current behavior

warnings described above

How to reproduce

the entity which triggers:

#[ORM\Table(name: 'point_import_service')]
#[ORM\Entity(repositoryClass: PointImportServiceRepository::class)]
class PointImportService
{
    #[ORM\Id]
    #[ORM\GeneratedValue]
    #[ORM\Column(name: 'id', type: Types::INTEGER)]
    private int $id;

    /** @var class-string */
    #[ORM\Column(name: 'class', type: Types::TEXT, nullable: false)]
    private string $class;

    #[ORM\ManyToOne(targetEntity: Provider::class, inversedBy: 'apps')]
    #[ORM\JoinColumn(name: 'provider_code', referencedColumnName: 'code', nullable: false)]
    private Provider $provider;

is that entity somewhat misconfigured? or is that a bug?

thanks for your effort ✌️

Originally created by @verfriemelt-dot-org on GitHub (May 8, 2023). <!-- Before reporting a BC break, please consult the upgrading document to make sure it's not an expected change: https://github.com/doctrine/orm/blob/2.9.x/UPGRADE.md --> ### BC Break Report | Q | A |------------ | ------ | BC Break | yes | Version | 2.15.1 (no warnings in 2.15.0) #### Summary this change: https://github.com/doctrine/orm/pull/10671/files#diff-c058a8444ffba22cecd48a76b9577187ef8eba003369d9b8d94313b4325d1b76 results in warnings due to seemling a wrong data type beeing passed? ``` Warning: Attempt to read property "name" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 694 Warning: Attempt to read property "unique" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 695 Warning: Attempt to read property "nullable" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 696 Warning: Attempt to read property "onDelete" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 697 Warning: Attempt to read property "columnDefinition" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 698 Warning: Attempt to read property "referencedColumnName" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 699 Warning: Attempt to read property "options" on string in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php on line 702 ``` #### Previous behavior no warnings #### Current behavior warnings described above #### How to reproduce the entity which triggers: ```php #[ORM\Table(name: 'point_import_service')] #[ORM\Entity(repositoryClass: PointImportServiceRepository::class)] class PointImportService { #[ORM\Id] #[ORM\GeneratedValue] #[ORM\Column(name: 'id', type: Types::INTEGER)] private int $id; /** @var class-string */ #[ORM\Column(name: 'class', type: Types::TEXT, nullable: false)] private string $class; #[ORM\ManyToOne(targetEntity: Provider::class, inversedBy: 'apps')] #[ORM\JoinColumn(name: 'provider_code', referencedColumnName: 'code', nullable: false)] private Provider $provider; ``` is that entity somewhat misconfigured? or is that a bug? thanks for your effort :v:

admin closed this issue 2026-01-22 15:45:33 +01:00

admin commented 2026-01-22 15:45:33 +01:00

Author

Owner

Copy Link

@verfriemelt-dot-org commented on GitHub (May 8, 2023):

mhmm, maybe thats a bit misleading, not sure.
here is a stacktrace when debugging that issue:

@verfriemelt-dot-org commented on GitHub (May 8, 2023): mhmm, maybe thats a bit misleading, not sure. here is a stacktrace when debugging that issue: 

admin commented 2026-01-22 15:45:34 +01:00

Author

Owner

Copy Link

@greg0ire commented on GitHub (May 8, 2023):

🤔 where does that point_target come from?

@greg0ire commented on GitHub (May 8, 2023): :thinking: where does that `point_target` come from?

admin commented 2026-01-22 15:45:35 +01:00

Author

Owner

Copy Link

@greg0ire commented on GitHub (May 8, 2023):

https://github.com/doctrine/orm/pull/10671 looks like it could cause the issue, Cc @BoShurik

@verfriemelt-dot-org can you try removing the lines introduced in that PR?

@greg0ire commented on GitHub (May 8, 2023): https://github.com/doctrine/orm/pull/10671 looks like it could cause the issue, Cc @BoShurik @verfriemelt-dot-org can you try removing the lines introduced in that PR?

admin commented 2026-01-22 15:45:35 +01:00

Author

Owner

Copy Link

@verfriemelt-dot-org commented on GitHub (May 8, 2023):

yes, can confirm.
to be exact this part causes the issue:

                    foreach ($joinTableAttribute->inverseJoinColumns as $joinColumn) {
                        $joinTable['inverseJoinColumns'][] = $this->joinColumnToArray($joinColumn);
                    }

seems we have assinged $joinTableAttribute->inverseJoinColumns as an instance of inverseJoinColumn instead of inverseJoinColumn[] and while iterating over that object, we get the first attribute which is name:

@verfriemelt-dot-org commented on GitHub (May 8, 2023): yes, can confirm. to be exact this part causes the issue: ``` foreach ($joinTableAttribute->inverseJoinColumns as $joinColumn) { $joinTable['inverseJoinColumns'][] = $this->joinColumnToArray($joinColumn); } ``` seems we have assinged `$joinTableAttribute->inverseJoinColumns` as an instance of `inverseJoinColumn` instead of `inverseJoinColumn[]` and while iterating over that object, we get the first attribute which is `name`: 

admin commented 2026-01-22 15:45:35 +01:00

Author

Owner

Copy Link

@verfriemelt-dot-org commented on GitHub (May 8, 2023):

when checking where this is coming from, it might be this wrongly defined entity?

    #[ORM\ManyToMany(targetEntity: Point::class, cascade: ['persist'])]
    #[ORM\JoinTable(name: 'point_has_points',  joinColumns: new ORM\JoinColumn(name: 'point_source'), inverseJoinColumns: new ORM\InverseJoinColumn(name: 'point_target'))]
    private Collection $childPoints;

i guess

    #[ORM\ManyToMany(targetEntity: Point::class, cascade: ['persist'])]
    #[ORM\JoinTable(name: 'point_has_points',  joinColumns: [new ORM\JoinColumn(name: 'point_source')], inverseJoinColumns: [new ORM\InverseJoinColumn(name: 'point_target')])]
    private Collection $childPoints;

would be correct? 🤔

well yes in fact, that works with the new version then.
okay, so i had an issue with my setup. might be a good idea to add a warning/exception? 🤔

thanks for your help anyways :)

@verfriemelt-dot-org commented on GitHub (May 8, 2023): when checking where this is coming from, it might be this wrongly defined entity? ``` #[ORM\ManyToMany(targetEntity: Point::class, cascade: ['persist'])] #[ORM\JoinTable(name: 'point_has_points', joinColumns: new ORM\JoinColumn(name: 'point_source'), inverseJoinColumns: new ORM\InverseJoinColumn(name: 'point_target'))] private Collection $childPoints; ``` i guess ``` #[ORM\ManyToMany(targetEntity: Point::class, cascade: ['persist'])] #[ORM\JoinTable(name: 'point_has_points', joinColumns: [new ORM\JoinColumn(name: 'point_source')], inverseJoinColumns: [new ORM\InverseJoinColumn(name: 'point_target')])] private Collection $childPoints; ``` would be correct? :thinking: well yes in fact, that works with the new version then. okay, so i had an issue with my setup. might be a good idea to add a warning/exception? :thinking: thanks for your help anyways :)

admin commented 2026-01-22 15:45:35 +01:00

Author

Owner

Copy Link

@greg0ire commented on GitHub (May 8, 2023):

okay, so i had an issue with my setup. might be a good idea to add a warning/exception? thinking

Maybe yes… did the schema validation Symfony command not warn about the issue?

@greg0ire commented on GitHub (May 8, 2023): > okay, so i had an issue with my setup. might be a good idea to add a warning/exception? thinking Maybe yes… did the schema validation Symfony command not warn about the issue?

admin commented 2026-01-22 15:45:36 +01:00

Author

Owner

Copy Link

@verfriemelt-dot-org commented on GitHub (May 9, 2023):

nope:

$ bin/console doctrine:schema:validate

Mapping
-------


 [OK] The mapping files are correct.

and with the 2.15.1 i got the same issue like we discussed here:

Mapping
-------


In AttributeDriver.php line 694:

  Warning: Attempt to read property "name" on string


doctrine:schema:validate [--em EM] [--skip-mapping] [--skip-sync]

@verfriemelt-dot-org commented on GitHub (May 9, 2023): nope: ``` $ bin/console doctrine:schema:validate Mapping ------- [OK] The mapping files are correct. ``` and with the 2.15.1 i got the same issue like we discussed here: ``` Mapping ------- In AttributeDriver.php line 694: Warning: Attempt to read property "name" on string doctrine:schema:validate [--em EM] [--skip-mapping] [--skip-sync] ```

admin commented 2026-01-22 15:45:37 +01:00

Author

Owner

Copy Link

@endelwar commented on GitHub (May 9, 2023):

Has the syntax below been deprecated and removed? I don't get any warning with both 2.14.3 and 2.15.0 (everything is working as expected)

#[ORM\ManyToMany(targetEntity: Product::class)]
#[ORM\JoinTable(name: 'news_product',
    schema: 'a_different_db',
    joinColumns: [
        ORM\JoinColumn::class => ['name' => 'news_id', 'referencedColumnName' => 'id'],
    ],
    inverseJoinColumns: [
        ORM\JoinColumn::class => ['name' => 'product_id', 'referencedColumnName' => 'id'],
    ]
)]
private Collection $products;

Upgrading to 2.15.1 my Symfony 5.4 project throws an ErrorException: "Warning: Attempt to read property "name" on array" here 9bc6f5b4ac/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php (L694) , coming from 9bc6f5b4ac/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php (L442)

If I change the joinColumn and inverseJoinColumns declaration 2.15.1 it works as expected:

#[ORM\ManyToMany(targetEntity: Product::class)]
#[ORM\JoinTable(name: 'news_product',
    schema: 'a_different_db',
    joinColumns: [
        new ORM\JoinColumn(name: 'news_id', referencedColumnName: 'id'),
    ],
    inverseJoinColumns: [
        new ORM\JoinColumn(name: 'product_id', referencedColumnName: 'id'),
    ]
)]
private Collection $products;

@endelwar commented on GitHub (May 9, 2023): Has the syntax below been deprecated and removed? I don't get any warning with both 2.14.3 and 2.15.0 (everything is working as expected) ```php #[ORM\ManyToMany(targetEntity: Product::class)] #[ORM\JoinTable(name: 'news_product', schema: 'a_different_db', joinColumns: [ ORM\JoinColumn::class => ['name' => 'news_id', 'referencedColumnName' => 'id'], ], inverseJoinColumns: [ ORM\JoinColumn::class => ['name' => 'product_id', 'referencedColumnName' => 'id'], ] )] private Collection $products; ``` Upgrading to 2.15.1 my Symfony 5.4 project throws an ErrorException: "Warning: Attempt to read property "name" on array" here https://github.com/doctrine/orm/blob/9bc6f5b4ac6f1e7d4248b2efbd01a748782075bc/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php#L694 , coming from https://github.com/doctrine/orm/blob/9bc6f5b4ac6f1e7d4248b2efbd01a748782075bc/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php#L442 If I change the `joinColumn` and `inverseJoinColumns` declaration 2.15.1 it works as expected: ```php #[ORM\ManyToMany(targetEntity: Product::class)] #[ORM\JoinTable(name: 'news_product', schema: 'a_different_db', joinColumns: [ new ORM\JoinColumn(name: 'news_id', referencedColumnName: 'id'), ], inverseJoinColumns: [ new ORM\JoinColumn(name: 'product_id', referencedColumnName: 'id'), ] )] private Collection $products; ```

admin commented 2026-01-22 15:45:37 +01:00

Author

Owner

Copy Link

@greg0ire commented on GitHub (May 9, 2023):

As far as I understood that's because these join column declarations did not do anything in previous versions. Please let me know if I am wrong.

@greg0ire commented on GitHub (May 9, 2023): As far as I understood that's because these join column declarations did not do anything in previous versions. Please let me know if I am wrong.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7147