doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

Add options (charset, collation) to DiscriminatorColumn to align it with Column options #7100

New Issue
Closed
opened 2026-01-22 15:44:41 +01:00 by admin · 1 comment
admin commented 2026-01-22 15:44:41 +01:00
Owner
Copy Link

Originally created by @janedbal on GitHub (Jan 26, 2023).

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

As stated in related dbal issue, when trying to declare charset and collation for discriminator column, the only option to use is columnDefinition (which causes the migration issue described in the dbal issue). I believe that DiscriminatorColumn is not that much different from regular Column and it should support the same features.

Originally created by @janedbal on GitHub (Jan 26, 2023). ### Feature Request <!-- Fill in the relevant information below to help triage your issue. --> | Q | A |------------ | ------ | New Feature | yes | RFC | no | BC Break | no #### Summary As stated in [related dbal issue](https://github.com/doctrine/dbal/pull/5869#issue-1556699509), when trying to declare charset and collation for discriminator column, the only option to use is `columnDefinition` (which causes the migration issue described in the dbal issue). I believe that [DiscriminatorColumn](https://github.com/doctrine/orm/blob/2.14.1/lib/Doctrine/ORM/Mapping/DiscriminatorColumn.php) is not that much different from regular [Column](https://github.com/doctrine/orm/blob/2.14.1/lib/Doctrine/ORM/Mapping/Column.php) and it should support the same features.
admin added the Bug label 2026-01-22 15:44:41 +01:00
admin closed this issue 2026-01-22 15:44:41 +01:00
admin commented 2026-01-22 15:44:41 +01:00
Author
Owner
Copy Link

@mattjanssen commented on GitHub (Feb 15, 2024):

Was this resolved with https://github.com/doctrine/orm/pull/10601 ?

@mattjanssen commented on GitHub (Feb 15, 2024): Was this resolved with https://github.com/doctrine/orm/pull/10601 ?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7100
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?