doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

Confusing parameter name $classes #6573

New Issue
Open
opened 2026-01-22 15:35:12 +01:00 by admin · 2 comments
admin commented 2026-01-22 15:35:12 +01:00
Owner
Copy Link

Originally created by @mvorisek on GitHub (Dec 2, 2020).

See SchemaTool::getUpdateSchemaSql(array $classes) method.

$classes represents array of ClassMetadata, no string class names.

Originally created by @mvorisek on GitHub (Dec 2, 2020). See `SchemaTool::getUpdateSchemaSql(array $classes)` method. `$classes` represents array of `ClassMetadata`, no string class names.
admin commented 2026-01-22 15:35:12 +01:00
Author
Owner
Copy Link

@greg0ire commented on GitHub (Dec 3, 2020):

Indeed: 404edd418b/lib/Doctrine/ORM/Tools/SchemaTool.php (L882-L905)

404edd418b/lib/Doctrine/ORM/Tools/SchemaTool.php (L137-L161)

The phpdoc could also be improved by using @psalm-param ClassMetadata[] $classes. Please send a PR.

@greg0ire commented on GitHub (Dec 3, 2020): Indeed: https://github.com/doctrine/orm/blob/404edd418b983d14a35c62ab297a4ead66ed2063/lib/Doctrine/ORM/Tools/SchemaTool.php#L882-L905 https://github.com/doctrine/orm/blob/404edd418b983d14a35c62ab297a4ead66ed2063/lib/Doctrine/ORM/Tools/SchemaTool.php#L137-L161 The phpdoc could also be improved by using `@psalm-param ClassMetadata[] $classes`. Please send a PR.
admin commented 2026-01-22 15:35:12 +01:00
Author
Owner
Copy Link

@mvorisek commented on GitHub (Dec 3, 2020):

I also advice to rename the params to $metadatas as used in other method prototypes.

@mvorisek commented on GitHub (Dec 3, 2020): I also advice to rename the params to `$metadatas` as used in other method prototypes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#6573
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?