Is it still necessary to wrap the __clone implementation in an if check? #6524

New Issue

admin · 2026-01-22T15:34:30+01:00

admin commented

2026-01-22 15:34:30 +01:00

Originally created by @sirdiego on GitHub (Aug 24, 2020).

The documentation says that __clone (and __wakeup) are not save to implement without an id check. But the Instantiator has an isSafeToClone method that checks if there is an __clone method implemented. So is it still necessary to wrap the __clone into the id check?

Thanks!

Originally created by @sirdiego on GitHub (Aug 24, 2020). The [documentation](https://github.com/doctrine/orm/blob/2.7/docs/en/cookbook/implementing-wakeup-or-clone.rst) says that __clone (and __wakeup) are not save to implement without an id check. But the Instantiator has an [isSafeToClone](https://github.com/doctrine/instantiator/blob/1.3.x/src/Doctrine/Instantiator/Instantiator.php#L197) method that checks if there is an __clone method implemented. So is it still necessary to wrap the __clone into the id check? Thanks!

admin closed this issue

2026-01-22 15:34:30 +01:00

admin commented

2026-01-22 15:34:31 +01:00

@beberlei commented on GitHub (Sep 13, 2020):

@sirdiego No, its not necessary anymore, that was before ReflectionClass::newInstanceWithoutConstructor was added in PHP 5.4 or 5.5

@beberlei commented on GitHub (Sep 13, 2020): @sirdiego No, its not necessary anymore, that was before `ReflectionClass::newInstanceWithoutConstructor` was added in PHP 5.4 or 5.5

admin referenced this issue

2026-01-22 16:06:09 +01:00

[PR #6524] Enable Strict Types declaration #10019

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#6524