Does getDQLPart/getDQLParts will be deprecated/removed ? #6429

New Issue

admin · 2026-01-22T15:33:02+01:00

admin commented

2026-01-22 15:33:02 +01:00

Originally created by @VincentLanglet on GitHub (Mar 23, 2020).

Support Question

I saw here
https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L1331
https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L1343
the following comment @todo Rename ... (or remove)

Personally I used them in some specific situation, for example if I want to add a more specific orderBy.

getQDLPart('orderBy')
resetDQLPart('order')
add my OrderBy
re-add the previous OrderBy

Is there a reason to want to withdraw theses methods ?
If not, can I remove the (or remove) comment ?

Originally created by @VincentLanglet on GitHub (Mar 23, 2020). ### Support Question I saw here https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L1331 https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L1343 the following comment `@todo Rename ... (or remove)` Personally I used them in some specific situation, for example if I want to add a more specific orderBy. - getQDLPart('orderBy') - resetDQLPart('order') - add my OrderBy - re-add the previous OrderBy Is there a reason to want to withdraw theses methods ? If not, can I remove the `(or remove)` comment ?

admin closed this issue

2026-01-22 15:33:03 +01:00

admin commented

2026-01-22 15:33:04 +01:00

@greg0ire commented on GitHub (Mar 23, 2020):

For future reference, these comments were introduced in 8d52967fcd 10 years ago

@greg0ire commented on GitHub (Mar 23, 2020): For future reference, these comments were introduced in https://github.com/doctrine/orm/commit/8d52967fcd8a5d956fa0b7327fe1b89a690a6c79 10 years ago

admin commented

2026-01-22 15:33:06 +01:00

@VincentLanglet commented on GitHub (Mar 23, 2020):

Whoah, didn't see this !

I propose to remove the todo: https://github.com/doctrine/orm/pull/8078

@VincentLanglet commented on GitHub (Mar 23, 2020): Whoah, didn't see this ! I propose to remove the todo: https://github.com/doctrine/orm/pull/8078

Sign in to join this conversation.