Extra update for self-referencing Many-To-One with NONE generator strategy during persist #6332

New Issue

admin · 2026-01-22T15:31:10+01:00

admin commented

2026-01-22 15:31:10 +01:00

Originally created by @sylfabre on GitHub (Oct 23, 2019).

Bug Report

Q	A
BC Break	no
Version	2.6.4

Summary

Using a self-referencing entity with a Many-To-One relationship set during the __construct() call with a NONE strategy for id generation leads to two queries:

first an INSERT
then an UPDATE for the relationship

Current behavior

this requires the relationship related column to accept NULL for the first INSERT

[2019-10-23 16:04:21] doctrine.DEBUG: INSERT INTO organization (id, legal_parent_id) VALUES (?, ?, ?, ?, ?, ?, ?) {"1":"[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")","2":null} []

this leads to a useless UPDATE query

[2019-10-23 16:04:21] doctrine.DEBUG: UPDATE organization SET legal_parent_id = ? WHERE id = ? ["[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")","[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")"] []

How to reproduce


CREATE TABLE `organization` (
  `id` binary(16) NOT NULL COMMENT '(DC2Type:uuid_binary_ordered_time)',
  `legal_parent_id` BINARY(16) NOT NULL COMMENT '(DC2Type:uuid_binary_ordered_time)',
  PRIMARY KEY (`id`),
  CONSTRAINT FK_C1EE637C9EB3F521 FOREIGN KEY (legal_parent_id) REFERENCES organization (id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

<?php

declare(strict_types=1);

namespace App\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;

/**
 * An Organization
 * @ORM\Entity(repositoryClass="App\Repository\OrganizationRepository")
 */
class Organization
{
    public function __construct()
    {
        $factory = clone \Ramsey\Uuid\Uuid::getFactory();
        $codec = new \Ramsey\Uuid\Codec\OrderedTimeCodec(
            $factory->getUuidBuilder()
        );
        $factory->setCodec($codec);
		$this->id = $factory->uuid1();
        $this->legalParent = $this;
        parent::__construct();
    }

    /**
     * Unique ID of the entity
     *
     * @ORM\Id()
     * @ORM\GeneratedValue(strategy="NONE")
     * @ORM\Column(type="uuid_binary_ordered_time", unique=true)
     */
    private $id;

    public function getId(): ?string
    {
        return $this->id->__toString();
    }

    /**
     * @var self
     * @ORM\ManyToOne(targetEntity="App\Entity\Organization")
     * @ORM\JoinColumn(fieldName="legal_parent_id", referencedColumnName="id", nullable=false)
     */
    protected $legalParent;

    public function getLegalParent(): self
    {
        return $this->legalParent;
    }

    public function setLegalParent(self $legalParent): self
    {
        $this->legalParent = $legalParent;

        return $this;
    }
}

Expected behavior

Only the INSERT query with legal_parent_id not NULL

[2019-10-23 16:04:21] doctrine.DEBUG: INSERT INTO organization (id, legal_parent_id) VALUES (?, ?, ?, ?, ?, ?, ?) {"1":"[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")","2":[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")} []

Possible solution

This comes from vendor/doctrine/orm/lib/Doctrine/ORM/Persisters/Entity/BasicEntityPersister.php

We could check if spl_object_hash($newVal) === spl_object_hash($entity) and if ClassMetadataInfo::GENERATOR_TYPE_NONE === $this->class->generatorType. If yes, then do not set $newVal = null; and do not schedule extra update.

I can provide a PR if you want

Originally created by @sylfabre on GitHub (Oct 23, 2019). ### Bug Report  | Q | A |------------ | ------ | BC Break | no | Version | 2.6.4 #### Summary Using a self-referencing entity with a Many-To-One relationship set during the `__construct()` call with a `NONE` strategy for id generation leads to two queries: - first an INSERT - then an UPDATE for the relationship #### Current behavior - this requires the relationship related column to accept `NULL` for the first `INSERT` `[2019-10-23 16:04:21] doctrine.DEBUG: INSERT INTO organization (id, legal_parent_id) VALUES (?, ?, ?, ?, ?, ?, ?) {"1":"[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")","2":null} []` - this leads to a useless `UPDATE` query `[2019-10-23 16:04:21] doctrine.DEBUG: UPDATE organization SET legal_parent_id = ? WHERE id = ? ["[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")","[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")"] []` #### How to reproduce ```sql CREATE TABLE `organization` ( `id` binary(16) NOT NULL COMMENT '(DC2Type:uuid_binary_ordered_time)', `legal_parent_id` BINARY(16) NOT NULL COMMENT '(DC2Type:uuid_binary_ordered_time)', PRIMARY KEY (`id`), CONSTRAINT FK_C1EE637C9EB3F521 FOREIGN KEY (legal_parent_id) REFERENCES organization (id) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4; ``` ```php <?php declare(strict_types=1); namespace App\Entity; use Doctrine\Common\Collections\ArrayCollection; use Doctrine\Common\Collections\Collection; use Doctrine\ORM\Mapping as ORM; /** * An Organization * @ORM\Entity(repositoryClass="App\Repository\OrganizationRepository") */ class Organization { public function __construct() { $factory = clone \Ramsey\Uuid\Uuid::getFactory(); $codec = new \Ramsey\Uuid\Codec\OrderedTimeCodec( $factory->getUuidBuilder() ); $factory->setCodec($codec); $this->id = $factory->uuid1(); $this->legalParent = $this; parent::__construct(); } /** * Unique ID of the entity * * @ORM\Id() * @ORM\GeneratedValue(strategy="NONE") * @ORM\Column(type="uuid_binary_ordered_time", unique=true) */ private $id; public function getId(): ?string { return $this->id->__toString(); } /** * @var self * @ORM\ManyToOne(targetEntity="App\Entity\Organization") * @ORM\JoinColumn(fieldName="legal_parent_id", referencedColumnName="id", nullable=false) */ protected $legalParent; public function getLegalParent(): self { return $this->legalParent; } public function setLegalParent(self $legalParent): self { $this->legalParent = $legalParent; return $this; } } ``` #### Expected behavior - Only the `INSERT` query with `legal_parent_id` not `NULL` `[2019-10-23 16:04:21] doctrine.DEBUG: INSERT INTO organization (id, legal_parent_id) VALUES (?, ?, ?, ?, ?, ?, ?) {"1":"[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")","2":[object] (Ramsey\\Uuid\\Uuid: \"c68555b0-f5ae-11e9-914e-38baf82a0624\")} []` #### Possible solution This comes from `vendor/doctrine/orm/lib/Doctrine/ORM/Persisters/Entity/BasicEntityPersister.php` ![image](https://user-images.githubusercontent.com/3177556/67414724-f3400e00-f5c3-11e9-9d4b-abb4bc298bf0.png) We could check if `spl_object_hash($newVal) === spl_object_hash($entity)` and if `ClassMetadataInfo::GENERATOR_TYPE_NONE === $this->class->generatorType`. If yes, then do not set `$newVal = null;` and do not schedule extra update. I can provide a PR if you want

admin added the Bug label 2026-01-22 15:31:10 +01:00

admin closed this issue

2026-01-22 15:31:10 +01:00

admin commented

2026-01-22 15:31:11 +01:00

@SenseException commented on GitHub (Oct 29, 2019):

Thank you for opening this issue. Pull requests are welcome if you like to provide one. The PR will also need integration test(s) with an entity close to the one of your example, but with a classic integer id. I assume your example was close to the actual use case of the project you're working on.

@SenseException commented on GitHub (Oct 29, 2019): Thank you for opening this issue. Pull requests are welcome if you like to provide one. The PR will also need integration test(s) with an entity close to the one of your example, but with a classic integer id. I assume your example was close to the actual use case of the project you're working on.

admin commented

2026-01-22 15:31:12 +01:00

@sylfabre commented on GitHub (Oct 30, 2019):

@SenseException PR done https://github.com/doctrine/orm/pull/7882

@sylfabre commented on GitHub (Oct 30, 2019): @SenseException PR done https://github.com/doctrine/orm/pull/7882

admin commented

2026-01-22 15:31:12 +01:00

@mpdude commented on GitHub (Jun 1, 2023):

Out of curiosity, do you really care about one UPDATE query more or less?

Or is the real motivation that a self-referencing (at the class level) association like this has to be defined as NULLable just because of the edge case that an entity might reference itself (at the entity level)?

I find the latter argument much stronger.

If that’s the case, we should also write the tests in a way to show that the entities can be inserted even with a non-NULLable association, not focus so much on the query count.

@mpdude commented on GitHub (Jun 1, 2023): Out of curiosity, do you really care about one UPDATE query more or less? Or is the real motivation that a self-referencing (at the class level) association like this has to be defined as NULLable just because of the edge case that an entity might reference itself (at the entity level)? I find the latter argument much stronger. If that’s the case, we should also write the tests in a way to show that the entities can be inserted even with a non-NULLable association, not focus so much on the query count.

admin commented

2026-01-22 15:31:12 +01:00

@sylfabre commented on GitHub (Jun 1, 2023):

@mpdude The real motivation is having to define a NULLable column.

You're right about the test, I'll work on a better version in my PR

@sylfabre commented on GitHub (Jun 1, 2023): @mpdude The real motivation is having to define a NULLable column. You're right about the test, I'll work on a better version in my PR

admin commented

2026-01-22 15:31:12 +01:00

@sylfabre commented on GitHub (Jul 11, 2023):

Fixed by https://github.com/doctrine/orm/pull/10735

@sylfabre commented on GitHub (Jul 11, 2023): Fixed by https://github.com/doctrine/orm/pull/10735

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#6332