findBy does not accept array anymore #6311

New Issue

Closed

opened 2026-01-22 15:30:36 +01:00 by admin · 7 comments

admin commented 2026-01-22 15:30:36 +01:00

Owner

Copy Link

Originally created by @JKoty on GitHub (Sep 26, 2019).

Originally assigned to: @JKoty on GitHub.

Bug Report

Q	A
BC Break	yes
Version	2.6.4

Summary

Using findBy with array generated SQL relatedEntity.id IN (Related\Entity\Full\Namespace(<id>), Related\Entity\Full\Namespace(<id2>)) instead of just relatedEntity.id IN (<id>, <id2>)

Current behavior

$arrayOfEntity = [$entity1, $entity2];
$result = $repository->findBy(['relatedEntity' => $arrayOfEntity])
// $result is empty though in version 2.6.3 it was not

How to reproduce

see above

Expected behavior

result contains related entity

Originally created by @JKoty on GitHub (Sep 26, 2019). Originally assigned to: @JKoty on GitHub. ### Bug Report | Q | A |------------ | ------ | BC Break | yes | Version | 2.6.4 #### Summary Using `findBy` with array generated SQL `relatedEntity.id IN (Related\Entity\Full\Namespace(<id>), Related\Entity\Full\Namespace(<id2>))` instead of just `relatedEntity.id IN (<id>, <id2>)` #### Current behavior ``` $arrayOfEntity = [$entity1, $entity2]; $result = $repository->findBy(['relatedEntity' => $arrayOfEntity]) // $result is empty though in version 2.6.3 it was not ``` #### How to reproduce see above #### Expected behavior result contains related entity

admin added the BugMissing Tests labels 2026-01-22 15:30:36 +01:00

admin closed this issue 2026-01-22 15:30:36 +01:00

admin commented 2026-01-22 15:30:37 +01:00

Author

Owner

Copy Link

@jaikdean commented on GitHub (Sep 26, 2019):

Possibly related to #7830

@jaikdean commented on GitHub (Sep 26, 2019): Possibly related to #7830

admin commented 2026-01-22 15:30:39 +01:00

Author

Owner

Copy Link

@SenseException commented on GitHub (Sep 29, 2019):

Let's keep this issue open until it is sure that there is a relation to the mentioned bug.

@SenseException commented on GitHub (Sep 29, 2019): Let's keep this issue open until it is sure that there is a relation to the mentioned bug.

admin commented 2026-01-22 15:30:41 +01:00

Author

Owner

Copy Link

@lcobucci commented on GitHub (Oct 1, 2019):

@JKoty I've tried to reproduce this issue in a functional test but failed miserably. Would please take a look at the sample test case to see what I've missed and send us PR with a failing test?

Sample test case

<?php
declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * @group GH7835
 */
final class GH7835Test extends OrmFunctionalTestCase
{
    protected function setUp() : void
    {
        parent::setUp();

        $this->setUpEntitySchema([GH7835Item::class]);
    }

    /**
     * @test
     */
    public function findByCanReceiveArrayOfObjectsAsFilter(): void
    {
        $parent1 = new GH7835Item(1, 'Test 1');
        $parent2 = new GH7835Item(2, 'Test 2');

        $this->_em->persist($parent1);
        $this->_em->persist($parent2);
        $this->_em->persist(new GH7835Item(3, 'Test 3', $parent1));
        $this->_em->persist(new GH7835Item(4, 'Test 4', $parent1));
        $this->_em->persist(new GH7835Item(5, 'Test 5', $parent2));
        $this->_em->flush();

        $items = $this->_em->getRepository(GH7835Item::class)->findBy(['parent' => [$parent1, $parent2]]);

        self::assertCount(3, $items);
    }
}

/** @Entity */
class GH7835Item
{
    /**
     * @Id()
     * @Column(type="integer")
     *
     * @var int
     */
    public $id;

    /**
     * @Column
     *
     * @var string
     */
    public $name;

    /**
     * @ManyToOne(targetEntity=GH7835Item::class)
     *
     * @var GH7835Item|null
     */
    public $parent;

    public function __construct(int $id, string $name, ?GH7835Item $parent = null)
    {
        $this->id = $id;
        $this->name = $name;
        $this->parent = $parent;
    }
}

@lcobucci commented on GitHub (Oct 1, 2019): @JKoty I've tried to reproduce this issue in a functional test but failed miserably. Would please take a look at the sample test case to see what I've missed and send us PR with a failing test? <details> <summary>Sample test case</summary> ```php <?php declare(strict_types=1); namespace Doctrine\Tests\ORM\Functional\Ticket; use Doctrine\Tests\OrmFunctionalTestCase; /** * @group GH7835 */ final class GH7835Test extends OrmFunctionalTestCase { protected function setUp() : void { parent::setUp(); $this->setUpEntitySchema([GH7835Item::class]); } /** * @test */ public function findByCanReceiveArrayOfObjectsAsFilter(): void { $parent1 = new GH7835Item(1, 'Test 1'); $parent2 = new GH7835Item(2, 'Test 2'); $this->_em->persist($parent1); $this->_em->persist($parent2); $this->_em->persist(new GH7835Item(3, 'Test 3', $parent1)); $this->_em->persist(new GH7835Item(4, 'Test 4', $parent1)); $this->_em->persist(new GH7835Item(5, 'Test 5', $parent2)); $this->_em->flush(); $items = $this->_em->getRepository(GH7835Item::class)->findBy(['parent' => [$parent1, $parent2]]); self::assertCount(3, $items); } } /** @Entity */ class GH7835Item { /** * @Id() * @Column(type="integer") * * @var int */ public $id; /** * @Column * * @var string */ public $name; /** * @ManyToOne(targetEntity=GH7835Item::class) * * @var GH7835Item|null */ public $parent; public function __construct(int $id, string $name, ?GH7835Item $parent = null) { $this->id = $id; $this->name = $name; $this->parent = $parent; } } ``` </details>

admin commented 2026-01-22 15:30:41 +01:00

Author

Owner

Copy Link

@JKoty commented on GitHub (Oct 2, 2019):

@lcobucci

Here you have.

Failing test case

<?php
declare(strict_types=1);
namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\ParameterType;
use Doctrine\ORM\Annotation as ORM;
use Doctrine\Tests\OrmFunctionalTestCase;


final class GH7835Test extends OrmFunctionalTestCase
{
	protected function setUp(): void
	{
		parent::setUp();

		$this->setUpEntitySchema([GH7835Item::class]);
	}

	/**
	 * @test
	 */
	public function findByCanReceiveArrayOfObjectsAsFilter(): void
	{
		$parent1 = new GH7835Item(1, 'Test 1');
		$parent2 = new GH7835Item(2, 'Test 2');

		$this->em->persist($parent1);
		$this->em->persist($parent2);
		$this->em->persist(new GH7835Item(3, 'Test 3', $parent1));
		$this->em->persist(new GH7835Item(4, 'Test 4', $parent1));
		$this->em->persist(new GH7835Item(5, 'Test 5', $parent2));
		$this->em->flush();

		$items = $this->em->getRepository(GH7835Item::class)->createQueryBuilder('it');
		$items->andWhere('it.parent IN (:parents)')->setParameter('parents', [$parent1, $parent2]);
		self::assertCount(3, $items->getQuery()->getResult()); // this works in both versions

		$items2 = $this->em->getRepository(GH7835Item::class)->createQueryBuilder('it2');
		$type = ParameterType::STRING + Connection::ARRAY_PARAM_OFFSET;
		$items2->andWhere('it2.parent IN (:parents)')->setParameter('parents', [$parent1, $parent2], $type);
		self::assertCount(3, $items2->getQuery()->getResult()); // this works only in 2.6.3

	}
}

/** @ORM\Entity() */
class GH7835Item
{
	/**
	 * @ORM\Id()
	 * @ORM\Column(type="integer")
	 *
	 * @var int
	 */
	public $id;

	/**
	 * @ORM\Column
	 *
	 * @var string
	 */
	public $name;

	/**
	 * @ORM\ManyToOne(targetEntity=GH7835Item::class)
	 *
	 * @var GH7835Item|null
	 */
	public $parent;

	public function __construct(int $id, string $name, ?GH7835Item $parent = null)
	{
		$this->id = $id;
		$this->name = $name;
		$this->parent = $parent;
	}


	public function __toString()
	{
		return 'object with id ' . $this->id;
	}
}

I have to correct myself, it's not really in findBy. I had facade over it which I did not notice. But I have done some digging and found out its in $type parameter of ->setParameter() method. So it is probably same issue as in #7830
I also had to add __toString method to entity.

@JKoty commented on GitHub (Oct 2, 2019): @lcobucci Here you have. <details> <summary>Failing test case</summary> ``` <?php declare(strict_types=1); namespace Doctrine\Tests\ORM\Functional\Ticket; use Doctrine\DBAL\Connection; use Doctrine\DBAL\ParameterType; use Doctrine\ORM\Annotation as ORM; use Doctrine\Tests\OrmFunctionalTestCase; final class GH7835Test extends OrmFunctionalTestCase { protected function setUp(): void { parent::setUp(); $this->setUpEntitySchema([GH7835Item::class]); } /** * @test */ public function findByCanReceiveArrayOfObjectsAsFilter(): void { $parent1 = new GH7835Item(1, 'Test 1'); $parent2 = new GH7835Item(2, 'Test 2'); $this->em->persist($parent1); $this->em->persist($parent2); $this->em->persist(new GH7835Item(3, 'Test 3', $parent1)); $this->em->persist(new GH7835Item(4, 'Test 4', $parent1)); $this->em->persist(new GH7835Item(5, 'Test 5', $parent2)); $this->em->flush(); $items = $this->em->getRepository(GH7835Item::class)->createQueryBuilder('it'); $items->andWhere('it.parent IN (:parents)')->setParameter('parents', [$parent1, $parent2]); self::assertCount(3, $items->getQuery()->getResult()); // this works in both versions $items2 = $this->em->getRepository(GH7835Item::class)->createQueryBuilder('it2'); $type = ParameterType::STRING + Connection::ARRAY_PARAM_OFFSET; $items2->andWhere('it2.parent IN (:parents)')->setParameter('parents', [$parent1, $parent2], $type); self::assertCount(3, $items2->getQuery()->getResult()); // this works only in 2.6.3 } } /** @ORM\Entity() */ class GH7835Item { /** * @ORM\Id() * @ORM\Column(type="integer") * * @var int */ public $id; /** * @ORM\Column * * @var string */ public $name; /** * @ORM\ManyToOne(targetEntity=GH7835Item::class) * * @var GH7835Item|null */ public $parent; public function __construct(int $id, string $name, ?GH7835Item $parent = null) { $this->id = $id; $this->name = $name; $this->parent = $parent; } public function __toString() { return 'object with id ' . $this->id; } } ``` </details> I have to correct myself, it's not really in findBy. I had facade over it which I did not notice. But I have done some digging and found out its in `$type` parameter of `->setParameter()` method. So it is probably same issue as in #7830 I also had to add `__toString` method to entity.

admin commented 2026-01-22 15:30:41 +01:00

Author

Owner

Copy Link

@lcobucci commented on GitHub (Oct 2, 2019):

@JKoty thanks! I'm not sure if using ParameterType::STRING + Connection::ARRAY_PARAM_OFFSET as type is actually supported and documented. How did you find this solution?

@lcobucci commented on GitHub (Oct 2, 2019): @JKoty thanks! I'm not sure if using `ParameterType::STRING + Connection::ARRAY_PARAM_OFFSET` as type is actually supported and documented. How did you find this solution?

admin commented 2026-01-22 15:30:42 +01:00

Author

Owner

Copy Link

@JKoty commented on GitHub (Oct 2, 2019):

@lcobucci Actually it's from package kdyby/doctrine (here), line 74) so I'm not sure why is it even there. Maybe it should be fixed in their package. Dunno.

@JKoty commented on GitHub (Oct 2, 2019): @lcobucci Actually it's from package [kdyby/doctrine](https://github.com/Kdyby/Doctrine) ([here](https://github.com/Kdyby/Doctrine/blob/master/src/Kdyby/Doctrine/QueryBuilder.php)), line 74) so I'm not sure why is it even there. Maybe it should be fixed in their package. Dunno.

admin commented 2026-01-22 15:30:42 +01:00

Author

Owner

Copy Link

@beberlei commented on GitHub (Dec 6, 2020):

Fixed in 2.7 as per related issue.

@beberlei commented on GitHub (Dec 6, 2020): Fixed in 2.7 as per related issue.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label Bug Missing Tests

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#6311