Different mapping driver returns different isTransient() response for same class #6156

New Issue

admin · 2026-01-22T15:27:53+01:00

admin commented

2026-01-22 15:27:53 +01:00

Originally created by @notrix on GitHub (Jan 11, 2019).

I have issue with embeddable class where:

AnnotationDriver returns
isTransient() === true
And FileDriver
isTransient() === false

AnnotationDriver skips classes that are not in \Doctrine\ORM\Mapping\Driver\AnnotationDriver::$entityAnnotationClasses
FileDriver accepts all classes if file exists (embeddable included)

jms/serializer doctrine object constructor depends on isTransient() response and with embeddable class if fails to construct object.

Originally created by @notrix on GitHub (Jan 11, 2019). I have issue with embeddable class where: AnnotationDriver returns **isTransient() === true** And FileDriver **isTransient() === false** AnnotationDriver skips classes that are not in \Doctrine\ORM\Mapping\Driver\AnnotationDriver::$entityAnnotationClasses FileDriver accepts all classes if file exists (embeddable included) jms/serializer doctrine object constructor depends on isTransient() response and with embeddable class if fails to construct object.

admin added the Bug Missing Tests labels 2026-01-22 15:27:53 +01:00

admin commented

2026-01-22 15:27:54 +01:00

@alcaeus commented on GitHub (Jan 11, 2019):

This can happen depending on the platform. For example, MongoDB ODM has EmbeddedDocument and other non-root documents in the corresponding list in AnnotationDriver, so assuming that a mapping file is valid, both FileDriver and AnnotationDriver will return the same value when queried for that class. I would assume this is a discrepancy in ORM.

@Majkl578 what do you think? Is this a general issue that we want to look at or is this an ORM-specific issue?

@alcaeus commented on GitHub (Jan 11, 2019): This can happen depending on the platform. For example, MongoDB ODM has `EmbeddedDocument` and other non-root documents in the corresponding list in AnnotationDriver, so assuming that a mapping file is valid, both `FileDriver` and `AnnotationDriver` will return the same value when queried for that class. I would assume this is a discrepancy in ORM. @Majkl578 what do you think? Is this a general issue that we want to look at or is this an ORM-specific issue?

admin commented

2026-01-22 15:27:54 +01:00

@notrix commented on GitHub (Jan 16, 2019):

IMHO it has nothing to do with platforms. doctrine/persistence lib has drivers that behaves differently.
Third party libs should not care which driver is used to collect class metadata.

Either annotation driver should consider all possible entity annotations (embeddable included) or file driver should look whats inside class metadata file and not just check if it exists.

@notrix commented on GitHub (Jan 16, 2019): IMHO it has nothing to do with platforms. `doctrine/persistence` lib has drivers that behaves differently. Third party libs should not care which driver is used to collect class metadata. Either annotation driver should consider all possible entity annotations (embeddable included) or file driver should look whats inside class metadata file and not just check if it exists.

admin commented

2026-01-22 15:27:55 +01:00

@Ocramius commented on GitHub (Jan 16, 2019):

An embeddable is indeed transient, as it cannot be persisted on its own (hence transient when seen without parent entity context): this should be corrected in the annotationdriver (in ORM).

@Ocramius commented on GitHub (Jan 16, 2019): An embeddable is indeed transient, as it cannot be persisted on its own (hence transient when seen without parent entity context): this should be corrected in the annotationdriver (in ORM).

admin commented

2026-01-22 15:27:55 +01:00

@notrix commented on GitHub (Jan 16, 2019):

If embeddable is transient, so annotation driver works as expected. File driver does not check file content and returns false on isTransient(EmbeddableClass). Should I create new issue in ORM lib?

@notrix commented on GitHub (Jan 16, 2019): If embeddable is transient, so annotation driver works as expected. File driver does not check file content and returns false on isTransient(EmbeddableClass). Should I create new issue in ORM lib?

admin commented

2026-01-22 15:27:56 +01:00

@Ocramius commented on GitHub (Jan 16, 2019):

I'd suggest directly writing a failing test case for ORM, if possible.

I don't fully understand the implications of changing this in ORM yet, as it may affect metadata loading.

@Ocramius commented on GitHub (Jan 16, 2019): I'd suggest directly writing a failing test case for ORM, if possible. I don't fully understand the implications of changing this in ORM yet, as it may affect metadata loading.

admin commented

2026-01-22 15:27:56 +01:00

@alcaeus commented on GitHub (Jan 16, 2019):

I don't fully understand the implications of changing this in ORM yet, as it may affect metadata loading.

Shouldn't be borked more than now since one driver already returns false 😉

@alcaeus commented on GitHub (Jan 16, 2019): > I don't fully understand the implications of changing this in ORM yet, as it may affect metadata loading. Shouldn't be borked more than now since one driver already returns `false` 😉

admin referenced this issue

2026-01-22 16:05:41 +01:00

[PR #6156] Allow doctrine/common 2.7 #9872

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#6156