mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
Documentation wrong? #6086
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @flaushi on GitHub (Oct 11, 2018).
Originally assigned to: @Majkl578 on GitHub.
I randomly found this remark in the FAQs:
https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/faq.html#i-access-a-variable-and-its-null-what-is-wrong
Is this true? All my entities have public fields, and no getters or setters, but doctrine does work fine. Also it is the first time I read that having private/protected fields with getter and setter is a must. Up to now I thought it is more or less a coding standard (and waste of space ;-))
@Ocramius commented on GitHub (Oct 15, 2018):
@flaushi yes, that's something that was fixed in
doctrine/orm2.4, where we allowed proxyingpublicproperties.If you want to help with the docs, send a patch to remove that paragraph :-)
@stollr commented on GitHub (Oct 18, 2018):
I have created a PR to remove that paragraph ;-)
@flaushi commented on GitHub (Oct 18, 2018):
Thanks! I wanted to do the same but could not find the paragraph anymore. I tought it had beed deleted already... anyway thanks!
@Majkl578 commented on GitHub (Nov 11, 2018):
#7434 merged.