add LIMIT on update query #5937

New Issue

admin · 2026-01-22T15:22:34+01:00

admin commented

2026-01-22 15:22:34 +01:00

Originally created by @safwanghamrawi on GitHub (Mar 29, 2018).

Originally assigned to: @safwanghamrawi on GitHub.

When we make an update query builder with setMaxResults to add LIMIT, the LIMIT is ignored in the class SqlWalker method walkUpdateStatement. Could we modify this function to be like:
`

/**
 * {@inheritdoc}
 */
public function walkUpdateStatement(AST\UpdateStatement $AST)
{
    $this->useSqlTableAliases = false;
    $this->rsm->isSelect      = false;
    $limit    = $this->query->getMaxResults();

    $sql = $this->walkUpdateClause($AST->updateClause)
        . $this->walkWhereClause($AST->whereClause);


    if ($limit !== null) {
        $sql = $this->platform->modifyLimitQuery($sql, $limit, null);
    }
    return $sql;
}

Originally created by @safwanghamrawi on GitHub (Mar 29, 2018). Originally assigned to: @safwanghamrawi on GitHub. When we make an update query builder with setMaxResults to add LIMIT, the LIMIT is ignored in the class SqlWalker method walkUpdateStatement. Could we modify this function to be like: ` /** * {@inheritdoc} */ public function walkUpdateStatement(AST\UpdateStatement $AST) { $this->useSqlTableAliases = false; $this->rsm->isSelect = false; $limit = $this->query->getMaxResults(); $sql = $this->walkUpdateClause($AST->updateClause) . $this->walkWhereClause($AST->whereClause); if ($limit !== null) { $sql = $this->platform->modifyLimitQuery($sql, $limit, null); } return $sql; }

admin added the Bug Missing Tests labels 2026-01-22 15:22:34 +01:00

admin commented

2026-01-22 15:22:36 +01:00

@Ocramius commented on GitHub (Mar 29, 2018):

@safwanghamrawi a test case showing a failure caused by this is required before considering any fixes.

@Ocramius commented on GitHub (Mar 29, 2018): @safwanghamrawi a test case showing a failure caused by this is required before considering any fixes.

admin referenced this issue

2026-01-22 16:05:26 +01:00

[PR #5937] Embeddables object as query parameter #9792

Sign in to join this conversation.