mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
Reflection to Closure bind rework #5808
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @KonstantinKuklin on GitHub (Dec 17, 2017).
Originally assigned to: @Majkl578 on GitHub.
Did anyone tried to move from reflection to ClosureBind in cases when we need to work with entity`s property?
Main reason of such refactoring is much better performance of closures.
BTW https://ocramius.github.io/blog/accessing-private-php-class-members-without-reflection/
@Ocramius commented on GitHub (Dec 17, 2017):
Usually leads to worse performance, but please check
ocramius/generated-hydrator if your aim is improving ORM performance for 3.x
On 17 Dec 2017 15:09, "Konstantin" notifications@github.com wrote:
@KonstantinKuklin commented on GitHub (Dec 17, 2017):
So, I got:
hydrator code: https://gist.github.com/KonstantinKuklin/c44daa558dcdfb5cee8e0d89c778c5d3
environment: PHP 7.0.22 (cli) (built: Aug 7 2017 14:07:27) ( NTS )
is 5-10% boost enough to move from reflection?
@Ocramius commented on GitHub (Dec 17, 2017):
No, needs to be much more to justify the change there. As I already
mentioned, the GeneratedHydrator project is where you might want to suggest
improvements.
After those are applied, we can work towards plugging in a (de-) hydration
abstraction in the ORM too.
On 17 Dec 2017 17:54, "Konstantin" notifications@github.com wrote:
@Majkl578 commented on GitHub (Dec 19, 2017):
We actually already have issue for generated hydrators: #2553. I'll close this one based on what @Ocramius said, but will add the other issue to 3.0 milestone so it doesn't get forgotten.