mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
Pagination LimitSubqueryWalker optimization #5765
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @plfort on GitHub (Nov 9, 2017).
Originally assigned to: @guilhermeblanco on GitHub.
LimitSubqueryWalker create useless select expressions when "resultVariable" are involved :
a82f6c5725/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryWalker.php (L76-L82)We need to "Preserve mixed data in query for ordering." only if these fields are used in the "order by" clause.
@plfort commented on GitHub (Nov 22, 2017):
The current behavior produces horrible performances when a lot of subselect are performed in the select clause.
@mvrhov commented on GitHub (Nov 22, 2017):
I don't remember exactly but.
@plfort commented on GitHub (Nov 22, 2017):
@mvrhov Sorry but I don't get the point, can you be more specific ?
@mvrhov commented on GitHub (Nov 22, 2017):
I just wanted to tell you, that there is the reason that this was kept.
@plfort commented on GitHub (Nov 23, 2017):
Ok but what do you mean with "postgresql requires this ...".
@mvrhov commented on GitHub (Nov 23, 2017):
That you should run the same query on whatever database you are using and the postgresql.
Most complaints here are from ppl. using MySQL which is not SQL standard conformant.
@Ocramius commented on GitHub (Dec 11, 2017):
Handled in #6820