doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

oneToMany orphanRemoval with unique - constraint violation #5739

New Issue
Open
opened 2026-01-22 15:16:08 +01:00 by admin · 31 comments
admin commented 2026-01-22 15:16:08 +01:00
Owner
Copy Link

Originally created by @akomm on GitHub (Oct 16, 2017).

I currently do not have time for the test, also because this blocks me: #6738. I try to add one asap.

Issue is the following:

Preconditions:

  • You have an OneToMany with orphanRemoval set from the one-side.
  • On the many-side you have a unique constraint

You do the following in a single transaction/flush:

  1. Remove some entities from the many-side
  2. Create new entities on the many-side

When the column value (unique constraint) on the removed entities (1) equals the column value (unique constraint) on the created entities (2) a constraint violation is raised.

Reason:
The created entities (2) are INSERTed before the removed entities (1) are DELETEd.

Found a fixed, similar issue, just ManyToMany: #2310

Originally created by @akomm on GitHub (Oct 16, 2017). I currently do not have time for the test, also because this blocks me: #6738. I try to add one asap. Issue is the following: Preconditions: - You have an _OneToMany_ with _orphanRemoval_ set from the _one_-side. - On the _many_-side you have a _unique constraint_ You do the following in a __single transaction/flush__: 1. Remove some entities from the _many_-side 2. Create new entities on the _many_-side When the column value (unique constraint) on the removed entities (1) equals the column value (unique constraint) on the created entities (2) a constraint violation is raised. Reason: The created entities (2) are INSERTed before the removed entities (1) are DELETEd. Found a fixed, similar issue, just _ManyToMany_: #2310
admin added the BugFailing Test labels 2026-01-22 15:16:08 +01:00
admin commented 2026-01-22 15:16:08 +01:00
Author
Owner
Copy Link

@lcobucci commented on GitHub (Oct 29, 2017):

@akomm thanks for reporting the issue, we do need a test though (we're also short on time). Send us something when you're available and we discuss on the PR.

@lcobucci commented on GitHub (Oct 29, 2017): @akomm thanks for reporting the issue, we do need a test though (we're also short on time). Send us something when you're available and we discuss on the PR.
admin commented 2026-01-22 15:16:08 +01:00
Author
Owner
Copy Link

@akomm commented on GitHub (Nov 2, 2017):

I resolved the #6738 issue but could not make a reproduction "quick" and worked around it removing the unique constraint temporary relying on code as long as the app is not in prod. Want to return to the reproduction test when rest is done, so I can enable the constraint again.

@akomm commented on GitHub (Nov 2, 2017): I resolved the #6738 issue but could not make a reproduction "quick" and worked around it removing the unique constraint temporary relying on code as long as the app is not in prod. Want to return to the reproduction test when rest is done, so I can enable the constraint again.
admin commented 2026-01-22 15:16:10 +01:00
Author
Owner
Copy Link

@julienb-allopneus commented on GitHub (Nov 17, 2017):

Hi,
We're facing the same problem but we won't just remove the constraint ;-)
Anyone working on this topic?

cc @nio-hevea @Myloth

@julienb-allopneus commented on GitHub (Nov 17, 2017): Hi, We're facing the same problem but we won't just remove the constraint ;-) Anyone working on this topic? cc @nio-hevea @Myloth
admin commented 2026-01-22 15:16:10 +01:00
Author
Owner
Copy Link

@lcobucci commented on GitHub (Nov 19, 2017):

@julienb-allopneus could you please send us a failing test case that reproduces that behaviour? It would help us a lot to identify and fix the issue you're describing.

You can find examples on 388afb46d0/tests/Doctrine/Tests/ORM/Functional/Ticket

@lcobucci commented on GitHub (Nov 19, 2017): @julienb-allopneus could you please send us a failing test case that reproduces that behaviour? It would help us a lot to identify and fix the issue you're describing. You can find examples on https://github.com/doctrine/doctrine2/tree/388afb46d0cb3ed0c51332e8df0de9e942c2690b/tests/Doctrine/Tests/ORM/Functional/Ticket
admin commented 2026-01-22 15:16:10 +01:00
Author
Owner
Copy Link

@julienb-allopneus commented on GitHub (Nov 20, 2017):

Hi @lcobucci ,
I'll work on this today, and keep you informed as soon as I can.

@julienb-allopneus commented on GitHub (Nov 20, 2017): Hi @lcobucci , I'll work on this today, and keep you informed as soon as I can.
admin commented 2026-01-22 15:16:10 +01:00
Author
Owner
Copy Link

@julienb-allopneus commented on GitHub (Nov 21, 2017):

Hi guys @lcobucci & @akomm ,

I have written a test in the following PR https://github.com/doctrine/doctrine2/pull/6838 , please have a look and tell me what's next :-)
FYI, I have no experience in doctrine contribution and doctrine internals .

Thanks,

Julien.

cc @nio-hevea @Myloth

@julienb-allopneus commented on GitHub (Nov 21, 2017): Hi guys @lcobucci & @akomm , I have written a test in the following PR https://github.com/doctrine/doctrine2/pull/6838 , please have a look and tell me what's next :-) FYI, I have no experience in doctrine contribution and doctrine internals . Thanks, Julien. cc @nio-hevea @Myloth
admin commented 2026-01-22 15:16:11 +01:00
Author
Owner
Copy Link

@julienb-allopneus commented on GitHub (Nov 29, 2017):

Hi all,

Any news/advice on the test I wrote?
@lcobucci , is it ok for you?

Thanks,

Julien.

@julienb-allopneus commented on GitHub (Nov 29, 2017): Hi all, Any news/advice on the test I wrote? @lcobucci , is it ok for you? Thanks, Julien.
admin commented 2026-01-22 15:16:11 +01:00
Author
Owner
Copy Link

@julienb-allopneus commented on GitHub (Jan 8, 2018):

Hi @lcobucci and @akomm ,

Any news on this issue?
I guess that we may remove the "Missing tests" label and requalify the issue.

Thanks,

Julien.

@julienb-allopneus commented on GitHub (Jan 8, 2018): Hi @lcobucci and @akomm , Any news on this issue? I guess that we may remove the "Missing tests" label and requalify the issue. Thanks, Julien.
admin commented 2026-01-22 15:16:12 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Mar 6, 2018):

I'm having this same issue on a OnToOne relationship as well (no matter which the owning side it).

Is this related to this issue, or is there some other documentation someone can point me at?

@toby-griffiths commented on GitHub (Mar 6, 2018): I'm having this same issue on a OnToOne relationship as well (no matter which the owning side it). Is this related to this issue, or is there some other documentation someone can point me at?
admin commented 2026-01-22 15:16:12 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Mar 6, 2018):

@Toby we'd need a test case to verify that.

On 6 Mar 2018 18:38, "Toby Griffiths" notifications@github.com wrote:

I'm having this same issue on a OnToOne relationship as well (no matter
which the owning side it).

Is this related to this issue, or is there some other documentation
someone can point me at?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/issues/6776#issuecomment-370864160,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakO86kAhc5wRGz95LNkqfQUwTU-acks5tbsl4gaJpZM4P6XxY
.

@Ocramius commented on GitHub (Mar 6, 2018): @Toby we'd need a test case to verify that. On 6 Mar 2018 18:38, "Toby Griffiths" <notifications@github.com> wrote: > I'm having this same issue on a OnToOne relationship as well (no matter > which the owning side it). > > Is this related to this issue, or is there some other documentation > someone can point me at? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/doctrine/doctrine2/issues/6776#issuecomment-370864160>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAJakO86kAhc5wRGz95LNkqfQUwTU-acks5tbsl4gaJpZM4P6XxY> > . >
admin commented 2026-01-22 15:16:12 +01:00
Author
Owner
Copy Link

@lcobucci commented on GitHub (Mar 7, 2018):

@Ocramius @toby-griffiths we do have a test case in #6838 - it needs to be updated, sure

@lcobucci commented on GitHub (Mar 7, 2018): @Ocramius @toby-griffiths we do have a test case in #6838 - it needs to be updated, sure
admin commented 2026-01-22 15:16:13 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Mar 7, 2018):

@Ocramius Should I add my case details here, or raise a new ticket?

@toby-griffiths commented on GitHub (Mar 7, 2018): @Ocramius Should I add my case details here, or raise a new ticket?
admin commented 2026-01-22 15:16:14 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Mar 7, 2018):

Or Raise a new Test Case, as per @lcobucci 's comment?

@toby-griffiths commented on GitHub (Mar 7, 2018): Or Raise a new Test Case, as per @lcobucci 's comment?
admin commented 2026-01-22 15:16:14 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Mar 7, 2018):

(Thanks for the prompt reply, btw)

@toby-griffiths commented on GitHub (Mar 7, 2018): (Thanks for the prompt reply, btw)
admin commented 2026-01-22 15:16:14 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Mar 12, 2018):

@lcobucci / @Ocramius is it possible to add a test case file to that existing Test Case PR (#6838)? Or should I raise a separate PR to include the OneToOne test case?

@toby-griffiths commented on GitHub (Mar 12, 2018): @lcobucci / @Ocramius is it possible to add a test case file to that existing Test Case PR (#6838)? Or should I raise a separate PR to include the OneToOne test case?
admin commented 2026-01-22 15:16:15 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Mar 12, 2018):

@toby-griffiths yeah, you'd need to send a PR against that fork

@Ocramius commented on GitHub (Mar 12, 2018): @toby-griffiths yeah, you'd need to send a PR against that fork
admin commented 2026-01-22 15:16:16 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Mar 12, 2018):

OK. Will do when I can find a moment.

@toby-griffiths commented on GitHub (Mar 12, 2018): OK. Will do when I can find a moment.
admin commented 2026-01-22 15:16:16 +01:00
Author
Owner
Copy Link

@artem328 commented on GitHub (Oct 20, 2018):

Any updates on this issue?

@artem328 commented on GitHub (Oct 20, 2018): Any updates on this issue?
admin commented 2026-01-22 15:16:16 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Oct 31, 2018):

Please advise if this PR needs modifying (& how) as I was unable to submit the PR to the julienb-allopneus/doctrine2 fork.

@toby-griffiths commented on GitHub (Oct 31, 2018): Please advise if this PR needs modifying (& how) as I was unable to submit the PR to the `julienb-allopneus/doctrine2` fork.
admin commented 2026-01-22 15:16:16 +01:00
Author
Owner
Copy Link

@elkangaroo commented on GitHub (Mar 6, 2019):

Is this still being worked on? I am a bit lost about the status here, but this bug is quiet annoying.
Please tell me if there is anything I can do to help.

@elkangaroo commented on GitHub (Mar 6, 2019): Is this still being worked on? I am a bit lost about the status here, but this bug is quiet annoying. Please tell me if there is anything I can do to help.
admin commented 2026-01-22 15:16:16 +01:00
Author
Owner
Copy Link

@SenseException commented on GitHub (Mar 8, 2019):

Failing tests were added and a bugfix PR is needed to make the tests work.

@SenseException commented on GitHub (Mar 8, 2019): Failing tests were added and a bugfix PR is needed to make the tests work.
admin commented 2026-01-22 15:16:16 +01:00
Author
Owner
Copy Link

@vincentbab commented on GitHub (Sep 2, 2019):

I'm also facing this bug and it's quite annoying.
I took a look at doctrine's internals but could not find an easy fix for this bug.
Doctrine always execute INSERTs before DELETEs.
Any ideas on how to fix this ?

@vincentbab commented on GitHub (Sep 2, 2019): I'm also facing this bug and it's quite annoying. I took a look at doctrine's internals but could not find an easy fix for this bug. Doctrine always execute INSERTs before DELETEs. Any ideas on how to fix this ?
admin commented 2026-01-22 15:16:17 +01:00
Author
Owner
Copy Link

@sannek8552 commented on GitHub (Sep 11, 2019):

@vincentbab seems like they don't want to fix that. I am olso faced with that issue and trying to find workaround

@sannek8552 commented on GitHub (Sep 11, 2019): @vincentbab seems like they don't want to fix that. I am olso faced with that issue and trying to find workaround
admin commented 2026-01-22 15:16:18 +01:00
Author
Owner
Copy Link

@akomm commented on GitHub (Sep 12, 2019):

@sannek8552 can't blame them, they do it in their free time, there is no paid core team supported by some company AFAIK, like in many other OOS projects.

@akomm commented on GitHub (Sep 12, 2019): @sannek8552 can't blame them, they do it in their free time, there is no paid core team supported by some company AFAIK, like in many other OOS projects.
admin commented 2026-01-22 15:16:18 +01:00
Author
Owner
Copy Link

@egor-dev commented on GitHub (Oct 17, 2019):

I'm also facing with this :(

@egor-dev commented on GitHub (Oct 17, 2019): I'm also facing with this :(
admin commented 2026-01-22 15:16:18 +01:00
Author
Owner
Copy Link

@beberlei commented on GitHub (Feb 15, 2020):

This is a long standing bug that should have an even older ticket (I remember it was open during 2.0 beta already). The problem is that we couldn't re-order insert after deletes for some other reason that I forgot at the moment.

@beberlei commented on GitHub (Feb 15, 2020): This is a long standing bug that should have an even older ticket (I remember it was open during 2.0 beta already). The problem is that we couldn't re-order insert after deletes for some other reason that I forgot at the moment.
admin commented 2026-01-22 15:16:18 +01:00
Author
Owner
Copy Link

@kirkmadera commented on GitHub (Oct 12, 2021):

I had a similar use case. I think it's better to handle it manually, until Doctrine is able to handle this more gracefully.

This method prevents deletes/inserts when an update will do the job also.

  1. Loop through all existing records, find matches and update them
  2. Remove all unmatched records
  3. Loop through all updates and create records for the ones that were not matched.

Example dealing with currencies:

            foreach ($currency->getExchangeRates() as $exchangeRate) {
                foreach ($data['exchangeRates'] as $exchangeRateData) {
                    if ($exchangeRate->getCurrencyTo()->getCode() == $exchangeRateData['currencyTo']) {
                        $exchangeRate->setRate($exchangeRateData['rate']);
                        continue 2;
                    }
                }

                $currency->removeExchangeRate($exchangeRate);
                $this->entityManager->remove($exchangeRate);
            }

            foreach ($data['exchangeRates'] as $exchangeRateData) {
                foreach ($currency->getExchangeRates() as $exchangeRate) {
                    if ($exchangeRate->getCurrencyTo()->getCode() == $exchangeRateData['currencyTo']) {
                        continue 2;
                    }
                }

                $exchangeRate = new CurrencyExchangeRate();
                $exchangeRate->setCurrencyTo($indexedCurrencies[$exchangeRateData['currencyTo']]);
                $exchangeRate->setRate($exchangeRateData['rate']);
                $currency->addExchangeRate($exchangeRate);
            }
@kirkmadera commented on GitHub (Oct 12, 2021): I had a similar use case. I think it's better to handle it manually, until Doctrine is able to handle this more gracefully. This method prevents deletes/inserts when an update will do the job also. 1. Loop through all existing records, find matches and update them 2. Remove all unmatched records 3. Loop through all updates and create records for the ones that were not matched. Example dealing with currencies: ``` foreach ($currency->getExchangeRates() as $exchangeRate) { foreach ($data['exchangeRates'] as $exchangeRateData) { if ($exchangeRate->getCurrencyTo()->getCode() == $exchangeRateData['currencyTo']) { $exchangeRate->setRate($exchangeRateData['rate']); continue 2; } } $currency->removeExchangeRate($exchangeRate); $this->entityManager->remove($exchangeRate); } foreach ($data['exchangeRates'] as $exchangeRateData) { foreach ($currency->getExchangeRates() as $exchangeRate) { if ($exchangeRate->getCurrencyTo()->getCode() == $exchangeRateData['currencyTo']) { continue 2; } } $exchangeRate = new CurrencyExchangeRate(); $exchangeRate->setCurrencyTo($indexedCurrencies[$exchangeRateData['currencyTo']]); $exchangeRate->setRate($exchangeRateData['rate']); $currency->addExchangeRate($exchangeRate); } ```
admin commented 2026-01-22 15:16:18 +01:00
Author
Owner
Copy Link

@Nek- commented on GitHub (Oct 15, 2021):

Since nobody posted it, here you go. This issue is related to https://github.com/doctrine/orm/issues/5109 and you should be aware of the long discussion there.

@Nek- commented on GitHub (Oct 15, 2021): Since nobody posted it, here you go. This issue is related to https://github.com/doctrine/orm/issues/5109 and you should be aware of the long discussion there.
admin commented 2026-01-22 15:16:18 +01:00
Author
Owner
Copy Link

@mpdude commented on GitHub (Jun 28, 2023):

It seems that having the DELETEs before the INSERTs would be a fix for this case. But, #10809 adds two examples that show why this cannot easily be done, at least not in general.

@mpdude commented on GitHub (Jun 28, 2023): It seems that having the DELETEs before the INSERTs would be a fix for this case. But, #10809 adds two examples that show why this cannot easily be done, at least not in general.
admin commented 2026-01-22 15:16:19 +01:00
Author
Owner
Copy Link

@jurchiks commented on GitHub (Nov 21, 2024):

I have found only one fix for this extremely annoying issue that took me many tries and several hours to work around, and that is, that I have to manually filter out removed orphans BEFORE adding new ones or updating existing ones, AND I have to flush the removed ones too:

private function setChildren(EntityManager $em, ParentEntity $parent, array $submittedChildren): void
{
    $existingChildren = $parent->getChildren();

    // region Workaround for 7 year old Doctrine bug.
    // ChildEntity has a unique index.
    // If a ChildEntity is deleted (i.e. ID not in $submittedChildren),
    // and a new one is added with the same values from the unique index columns,
    // Doctrine first tries to add the new one - and catches a UniqueConstraintViolationException,
    // never even reaching the orphanRemoval part.
    // Thus, we are forced to manually remove the orphans ourselves...
    $existingChildIds = $existingChildren->getKeys(); // indexBy="id"
    $updatedChildIds = array_filter(array_column($submittedChildren, 'id'));
    $deletedChildIds = array_diff($existingChildIds, $updatedChildIds);

    foreach ($deletedChildIds as $deletedId) {
        $em->remove($existingChildren[$deletedId]);
    }

    $em->flush(); // Doesn't work without this.
    // endregion

    foreach ($submittedChildren as ['id' => $childId, 'fieldA' => $fieldA, 'fieldB' => $fieldB]) {
        $child = $existingChildren[$childId] ?? new ChildEntity();
        $child->setFieldA($fieldA);
        $child->setFieldB($fieldB);

        if (!$child->getId()) {
            $parent->addChild($child);
        }
    }
}

Personally I would suggest adding a flag to the OneToMany relation, something like deleteBeforeInsertion=true. I presume for those to whom this situation applies, many would want exactly this, and those that wouldn't most likely require a completely custom solution anyway.

@jurchiks commented on GitHub (Nov 21, 2024): I have found only one fix for this extremely annoying issue that took me many tries and several hours to work around, and that is, that I have to manually filter out removed orphans BEFORE adding new ones or updating existing ones, AND I have to flush the removed ones too: ``` private function setChildren(EntityManager $em, ParentEntity $parent, array $submittedChildren): void { $existingChildren = $parent->getChildren(); // region Workaround for 7 year old Doctrine bug. // ChildEntity has a unique index. // If a ChildEntity is deleted (i.e. ID not in $submittedChildren), // and a new one is added with the same values from the unique index columns, // Doctrine first tries to add the new one - and catches a UniqueConstraintViolationException, // never even reaching the orphanRemoval part. // Thus, we are forced to manually remove the orphans ourselves... $existingChildIds = $existingChildren->getKeys(); // indexBy="id" $updatedChildIds = array_filter(array_column($submittedChildren, 'id')); $deletedChildIds = array_diff($existingChildIds, $updatedChildIds); foreach ($deletedChildIds as $deletedId) { $em->remove($existingChildren[$deletedId]); } $em->flush(); // Doesn't work without this. // endregion foreach ($submittedChildren as ['id' => $childId, 'fieldA' => $fieldA, 'fieldB' => $fieldB]) { $child = $existingChildren[$childId] ?? new ChildEntity(); $child->setFieldA($fieldA); $child->setFieldB($fieldB); if (!$child->getId()) { $parent->addChild($child); } } } ``` Personally I would suggest adding a flag to the `OneToMany` relation, something like `deleteBeforeInsertion=true`. I presume for those to whom this situation applies, many would want exactly this, and those that wouldn't most likely require a completely custom solution anyway.
admin commented 2026-01-22 15:16:19 +01:00
Author
Owner
Copy Link

@toby-griffiths commented on GitHub (Jan 14, 2025):

Please advise if this PR needs modifying (& how) as I was unable to submit the PR to the julienb-allopneus/doctrine2 fork.

My PR (https://github.com/doctrine/orm/pull/7450) got closed for inactivity. Anyone able to re-open, or advise if I should re-submit it as a new PR? If so, how do I target the correct branch?

@toby-griffiths commented on GitHub (Jan 14, 2025): > Please advise if this PR needs modifying (& how) as I was unable to submit the PR to the `julienb-allopneus/doctrine2` fork. My PR (https://github.com/doctrine/orm/pull/7450) got closed for inactivity. Anyone able to re-open, or advise if I should re-submit it as a new PR? If so, how do I target the correct branch?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug Failing Test
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#5739
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?