doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

Proxy generation for embedded/transient classes #5645

New Issue
Closed
opened 2026-01-22 15:13:39 +01:00 by admin · 2 comments
admin commented 2026-01-22 15:13:39 +01:00
Owner
Copy Link

Originally created by @bendavies on GitHub (Aug 15, 2017).

Originally assigned to: @Ocramius on GitHub.

Due to https://github.com/doctrine/common/pull/771, proxy generation will now fail if a final class is used as an embedded.

We should skip proxy generation for abstract classes, mapped superclassesses, embeddables.

Originally created by @bendavies on GitHub (Aug 15, 2017). Originally assigned to: @Ocramius on GitHub. Due to https://github.com/doctrine/common/pull/771, proxy generation will now fail if a final class is used as an embedded. We should skip proxy generation for abstract classes, mapped superclassesses, embeddables.
admin added the BugMissing TestsRegression labels 2026-01-22 15:13:39 +01:00
admin closed this issue 2026-01-22 15:13:39 +01:00
admin commented 2026-01-22 15:13:39 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Aug 15, 2017):

The criteria should be to skip generation on any transient/hack type (anything not directly instantiable). The example above is precisely about embeddables, which are perfectly fine to be mapped from final classes.

@Ocramius commented on GitHub (Aug 15, 2017): The criteria should be to skip generation on any transient/hack type (anything not directly instantiable). The example above is precisely about embeddables, which are perfectly fine to be mapped from `final` classes.
admin commented 2026-01-22 15:13:40 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Aug 16, 2017):

Handled in #6626

@Ocramius commented on GitHub (Aug 16, 2017): Handled in #6626
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug Missing Tests Regression
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#5645
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?