mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
HHVM support #5522
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lcobucci on GitHub (May 5, 2017).
Originally assigned to: @lcobucci on GitHub.
We're struggling to support HHVM properly on our projects:
So it's time to rethink if we still want to guarantee HHVM support, the reasons are:
@Ocramius commented on GitHub (May 5, 2017):
Overall, I feel bad for dropping HHVM support, but lack of latest versions by default on CI, as well as incompatibilities with PHP 5, 7, 7.1 are starting to become an issue. Community usage is also very low, since PHP 7 made most interactions as fast as on HHVM.
We need to drop it though, as we need to bump the minimum version to PHP 7.1 anyway.
@alcaeus commented on GitHub (May 5, 2017):
Pinging @Seldaek - he did publish some HHVM stats from Packagist a while back and mentioned in IRC he'd post some current numbers soon. Quote:
@Majkl578 commented on GitHub (May 5, 2017):
Here: https://github.com/composer/composer/issues/6230#issuecomment-284426560
Maybe someone from Facebook could share their vision regarding compatibility, but it's been years and even many PHP 5 bugs are still unfixed, not even taking 7.0/7.1 into consideration. There is still ~250 open issues marked PHP 5 incompatibility and another ~75 marked PHP 7 incompatibility. There are also 43 issues marked wontfix which are PHP 5 incomatiblities.
I initially sent some bugfixes and another bunch of issues to HHVM, but now I just have a feeling that HHVM has its own path with PHP compatibility not being a priority.
Btw Symfony still seems to actively ship HHVM support, it'd be interesting to know their point of view, regarding HHVM + Symfony 4.
@theofidry commented on GitHub (May 5, 2017):
@Majkl578 Symfony doesn't provide any guarantee for HHVM, but accept fixes for it. Cf. https://github.com/symfony/symfony/issues/18922
@Majkl578 commented on GitHub (May 5, 2017):
@theofidry: Thanks for the link; Symfony doesn't have HHVM in allowed failures so they apparently still do care enough. :)
@lcobucci commented on GitHub (May 7, 2017):
@Ocramius since we had a blogpost about the HHVM roadmap should we write something again?
@Seldaek commented on GitHub (May 7, 2017):
Here you go https://seld.be/notes/php-versions-stats-2017-1-edition
@KennedyTedesco commented on GitHub (May 7, 2017):
Laravel doesn't follow HHVM since: https://github.com/laravel/framework/pull/14530
@szymach commented on GitHub (May 12, 2017):
It could be dropped for version 3 and reintroduced if there really will be a demand. Something I highly doubt, of course.
I believe this project does not need things dragging it down and that what HHVM support currently is - a minor feature requiring a lot of work, postponing important features.
@Majkl578 commented on GitHub (May 12, 2017):
I actually don't think this would have to wait for next major. Similarly to the PHP versions which are dropped/bumped in minor versions too...
@Ocramius commented on GitHub (Jun 20, 2017):
Handled in #6507 (for ORM)