doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-433: @ChangeTrackingPolicy values are not converted to integers #540

New Issue
Closed
opened 2026-01-22 12:41:51 +01:00 by admin · 7 comments
admin commented 2026-01-22 12:41:51 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Mar 16, 2010).

Jira issue originally created by user ksid:

The value specified on the @ChangeTrackingPolicy annotation does not get converted to it's constant counterpart.

@ChangeTrackingPolicy("NOTIFY") is stored on the ClassMetadataInfo class as the string value "NOTIFY" and not converted to ClassMetadataInfo::CHANGETRACKING_NOTIFY. Passing an integer value works as expected.

This means all ClassMetadataInfo#isChangeTracking* methods return false. I've attached the patch I'm currently using based off r7404.

Originally created by @doctrinebot on GitHub (Mar 16, 2010). Jira issue originally created by user ksid: The value specified on the @ChangeTrackingPolicy annotation does not get converted to it's constant counterpart. @ChangeTrackingPolicy("NOTIFY") is stored on the ClassMetadataInfo class as the string value "NOTIFY" and not converted to ClassMetadataInfo::CHANGETRACKING_NOTIFY. Passing an integer value works as expected. This means all ClassMetadataInfo#isChangeTracking\* methods return false. I've attached the patch I'm currently using based off r7404.
admin added the Bug label 2026-01-22 12:41:51 +01:00
admin closed this issue 2026-01-22 12:41:52 +01:00
admin commented 2026-01-22 12:41:53 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Mar 18, 2010):

Comment created by romanb:

This should be fixed now in trunk.

@doctrinebot commented on GitHub (Mar 18, 2010): Comment created by romanb: This should be fixed now in trunk.
admin commented 2026-01-22 12:41:53 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Mar 18, 2010):

Comment created by bjori:

That looks like a typo to me Roman. Shouldn't it be $changeTrackingAnnot?

         $changeTrackingAnnot = $classAnnotations['Doctrine\ORM\Mapping\ChangeTrackingPolicy'];

  •        $metadata->setChangeTrackingPolicy(constant('\Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_' . $inheritanceTypeAnnot->value));

  •        $metadata->setChangeTrackingPolicy(constant('\Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_' . $changeTrackingAnnot->value));
@doctrinebot commented on GitHub (Mar 18, 2010): Comment created by bjori: That looks like a typo to me Roman. Shouldn't it be $changeTrackingAnnot? ``` $changeTrackingAnnot = $classAnnotations['Doctrine\ORM\Mapping\ChangeTrackingPolicy']; ``` - $metadata->setChangeTrackingPolicy(constant('\Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_' . $inheritanceTypeAnnot->value)); - $metadata->setChangeTrackingPolicy(constant('\Doctrine\ORM\Mapping\ClassMetadata::CHANGETRACKING_' . $changeTrackingAnnot->value));
admin commented 2026-01-22 12:41:54 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Mar 18, 2010):

Comment created by ksid:

Thanks Roman. Looks like the update has a few typos. I'll upload a patch for this in a moment.

@doctrinebot commented on GitHub (Mar 18, 2010): Comment created by ksid: Thanks Roman. Looks like the update has a few typos. I'll upload a patch for this in a moment.
admin commented 2026-01-22 12:41:55 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Mar 18, 2010):

Comment created by romanb:

Whoops. Sorry. Fixed now. Looks like we need some more test coverage for that.

@doctrinebot commented on GitHub (Mar 18, 2010): Comment created by romanb: Whoops. Sorry. Fixed now. Looks like we need some more test coverage for that.
admin commented 2026-01-22 12:41:55 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Mar 18, 2010):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Mar 18, 2010): Issue was closed with resolution "Fixed"
admin commented 2026-01-22 12:41:55 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Mar 18, 2010):

Comment created by ksid:

Thanks Roman. Had the comment window open for a while so Hannes got in there before me.

On a side note, shouldn't ClassMetadataInfo be used instead of ClassMetadata? Also, all constant() calls do not start the class names with a backslash with the exception of lines 176 and 198.

@doctrinebot commented on GitHub (Mar 18, 2010): Comment created by ksid: Thanks Roman. Had the comment window open for a while so Hannes got in there before me. On a side note, shouldn't ClassMetadataInfo be used instead of ClassMetadata? Also, all constant() calls do not start the class names with a backslash with the exception of lines 176 and 198.
admin commented 2026-01-22 12:41:56 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Dec 13, 2015):

Imported 1 attachments from Jira into https://gist.github.com/04b179732418017473a7

@doctrinebot commented on GitHub (Dec 13, 2015): Imported 1 attachments from Jira into https://gist.github.com/04b179732418017473a7 - [10485_changetrackingfix.patch](https://gist.github.com/04b179732418017473a7#file-10485_changetrackingfix-patch)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?