DDC-42: the DQL parser does not support boolean literal values #54

New Issue

admin · 2026-01-22T12:25:28+01:00

admin commented

2026-01-22 12:25:28 +01:00

Originally created by @doctrinebot on GitHub (Oct 12, 2009).

Jira issue originally created by user itoijala:

The parser does not support boolean literal values. This means that comparisons like e.unlocked = true result in a syntax error. This is not what is intended, since both documentation and comments in the code Doctrine\ORM\Query\Parser.php line 1870 say that boolean literals are supported.

I have a possible fix. I don't know if it is the best way to fix this.

OLD:

/****
     * Literal ::= string | char | integer | float | boolean
     *
     * @return string
     */
    public function Literal()
    {
        switch ($this->_lexer->lookahead['type']) {
            case Lexer::T_STRING:
            case Lexer::T_INTEGER:
            case Lexer::T_FLOAT:
                $this->match($this->_lexer->lookahead['value']);
                return $this->_lexer->token['value'];
            default:
                $this->syntaxError('Literal');
        }
    }

NEW:

/****
     * Literal ::= string | char | integer | float | boolean
     *
     * @return string
     */
    public function Literal()
    {
        switch ($this->_lexer->lookahead['type']) {
            case Lexer::T_STRING:
            case Lexer::T_INTEGER:
            case Lexer::T_FLOAT:
                $this->match($this->_lexer->lookahead['value']);
                return $this->_lexer->token['value'];
            case Lexer::T_TRUE:
            case Lexer::T_FALSE:
                $this->match($this->_lexer->lookahead['value']);
                return $this->*em->getConnection()->getDatabasePlatform()->convertBooleans(strtolower($this->*lexer->token['value']) == 'true' ? true : false);
            default:
                $this->syntaxError('Literal');
        }
    }

Using convertBooleans is important. Otherwise the sql will have 'true' or 'false'.

Cases T_TRUE and T_FALSE should also be added to ArithmeticPrimary(). (line 2048)

Originally created by @doctrinebot on GitHub (Oct 12, 2009). Jira issue originally created by user itoijala: The parser does not support boolean literal values. This means that comparisons like e.unlocked = true result in a syntax error. This is not what is intended, since both documentation and comments in the code Doctrine\ORM\Query\Parser.php line 1870 say that boolean literals are supported. I have a possible fix. I don't know if it is the best way to fix this. OLD: ``` /**** * Literal ::= string | char | integer | float | boolean * * @return string */ public function Literal() { switch ($this->_lexer->lookahead['type']) { case Lexer::T_STRING: case Lexer::T_INTEGER: case Lexer::T_FLOAT: $this->match($this->_lexer->lookahead['value']); return $this->_lexer->token['value']; default: $this->syntaxError('Literal'); } } ``` NEW: ``` /**** * Literal ::= string | char | integer | float | boolean * * @return string */ public function Literal() { switch ($this->_lexer->lookahead['type']) { case Lexer::T_STRING: case Lexer::T_INTEGER: case Lexer::T_FLOAT: $this->match($this->_lexer->lookahead['value']); return $this->_lexer->token['value']; case Lexer::T_TRUE: case Lexer::T_FALSE: $this->match($this->_lexer->lookahead['value']); return $this->*em->getConnection()->getDatabasePlatform()->convertBooleans(strtolower($this->*lexer->token['value']) == 'true' ? true : false); default: $this->syntaxError('Literal'); } } ``` Using convertBooleans is important. Otherwise the sql will have 'true' or 'false'. Cases T_TRUE and T_FALSE should also be added to ArithmeticPrimary(). (line 2048)

admin added the Bug label 2026-01-22 12:25:28 +01:00

admin closed this issue

2026-01-22 12:25:28 +01:00

admin commented

2026-01-22 12:25:29 +01:00

@doctrinebot commented on GitHub (Oct 12, 2009):

Comment created by romanb:

Thanks, I will work on this.

One thing for your understanding though: The task of the parser is only to accept or deny input, thereby building up a syntax tree. Afterwards, one or more tree walkers can walk down this tree to do something with it. Normally this is just the SqlWalker that produces SQL. So it is the task of this SqlWalker to properly quote the literals. The Parser does not even care what the output will be.

@doctrinebot commented on GitHub (Oct 12, 2009): Comment created by romanb: Thanks, I will work on this. One thing for your understanding though: The task of the parser is only to accept or deny input, thereby building up a syntax tree. Afterwards, one or more tree walkers can walk down this tree to do something with it. Normally this is just the SqlWalker that produces SQL. So it is the task of this SqlWalker to properly quote the literals. The Parser does not even care what the output will be.

admin commented

2026-01-22 12:25:30 +01:00

@doctrinebot commented on GitHub (Oct 13, 2009):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Oct 13, 2009): Issue was closed with resolution "Fixed"

admin referenced this issue

2026-01-22 15:56:09 +01:00

[PR #54] [CLOSED] [DDC-217] Cache SQL results before hydration (and not after). #7647

admin referenced this issue

2026-01-22 15:56:10 +01:00

[PR #54] [DDC-217] Cache SQL results before hydration (and not after). #7651

Sign in to join this conversation.