doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

Minor docblock issue ResultSetMappingBuilder #5306

New Issue
Closed
opened 2026-01-22 15:04:01 +01:00 by admin · 1 comment
admin commented 2026-01-22 15:04:01 +01:00
Owner
Copy Link

Originally created by @arjank on GitHub (Oct 27, 2016).

Originally assigned to: @Ocramius on GitHub.

The docblock of ResultSetMappingBuilder::addJoinedEntityFromClassMetadata() in the 2.5 branch (and all previous 2.x branches) indicates that $relation should be an object. But the parameter is passed as-is to ResultSetMapping::addJoinedEntityResult() which expects it to be a string (that has been updated in commit cb31798). Would it be possible to backport commit 5481e0f from master to (at least) the 2.5 branch so the docblock correctly indicates what is expected?

Originally created by @arjank on GitHub (Oct 27, 2016). Originally assigned to: @Ocramius on GitHub. The docblock of `ResultSetMappingBuilder::addJoinedEntityFromClassMetadata()` in the 2.5 branch (and all previous 2.x branches) indicates that $relation should be an object. But the parameter is passed as-is to `ResultSetMapping::addJoinedEntityResult()` which expects it to be a string (that has been updated in commit cb31798). Would it be possible to backport commit 5481e0f from master to (at least) the 2.5 branch so the docblock correctly indicates what is expected?
admin added the Won't FixDocumentation labels 2026-01-22 15:04:01 +01:00
admin closed this issue 2026-01-22 15:04:02 +01:00
admin commented 2026-01-22 15:04:03 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Oct 27, 2016):

Sorry, not going to backport documentation issues: simply not worth the additional time.

@Ocramius commented on GitHub (Oct 27, 2016): Sorry, not going to backport documentation issues: simply not worth the additional time.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Documentation Won't Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#5306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?