mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-421: Add getFieldValue on ClassMetadata class #526
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Mar 13, 2010).
Originally assigned to: @beberlei on GitHub.
Jira issue originally created by user seldaek:
I would like the attached patch to be applied since it allows you to use the ClassMetadata in a much more obvious and consistent way.
i.e. it allows you to do :
{quote}
$this->_class->setFieldValue($entity, $field, 35);
$this->_class->getFieldValue($entity, $field);
{quote}
instead of the current:
{quote}
$this->_class->setFieldValue($entity, $field, 35);
$this->_class->getReflectionProperty($field)->getValue($entity);
{quote}
I am using the new style already in the NestedSet extension so it would be good if you could apply it fairly quickly if you agree.
@doctrinebot commented on GitHub (Mar 13, 2010):
Comment created by @beberlei:
please use $class->reflFields[$field]->getValue()
@doctrinebot commented on GitHub (Mar 13, 2010):
Issue was closed with resolution "Won't Fix"
@doctrinebot commented on GitHub (Mar 13, 2010):
Comment created by romanb:
I think its OK to add this method, otherwise we would need to remove setFieldValue also for consistency. As an explanation for Jordi why Benjamin mentioned using reflFields is that we use this public property inside Doctrine for performance reasons (access + serialization) but for user code its probably mostly OK to use the more explicit variants.
This method will be incuded in my next commit where I remove a lot of unnecessary other boilerplate.
@doctrinebot commented on GitHub (Mar 14, 2010):
Comment created by seldaek:
Good, thank you, I was getting ready for war when I read Benjamin's response, but I'm glad someone got what I meant :) I'll keep using my hacked version until it's applied then.
@doctrinebot commented on GitHub (Dec 13, 2015):
Imported 1 attachments from Jira into https://gist.github.com/db7b74e7ee8d534dab50