doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

Remove PHP 5.4 from travis builds #5145

New Issue
Closed
opened 2026-01-22 14:59:37 +01:00 by admin · 2 comments
admin commented 2026-01-22 14:59:37 +01:00
Owner
Copy Link

Originally created by @tPl0ch on GitHub (Jun 8, 2016).

Originally assigned to: @Ocramius on GitHub.

PHP 5.4 has reached end of life I don't understand why the travis run for PHP 5.4 is still required. See https://travis-ci.org/doctrine/doctrine2/jobs/135986241

It currently breaks travis builds for new PRs, i.e. the UnitOfWorkTest is using the Country::class notation which was introduced in PHP 5.5 (which will actually reach EOL very soon, too).

Not sure if making UnitOfWorkTest use get_class() for now, or just remove PHP 5.4 from the travis build.

$ php -v
PHP 5.4.40-1~dotdeb+wheezy.1 (cli) (built: Apr 22 2015 06:50:56) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies
    with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans
    with Zend OPcache v7.0.3-dev, Copyright (c) 1999-2013, by Zend Technologies
$ ./vendor/bin/phpunit tests/Doctrine/Tests/ORM/UnitOfWorkTest.php 
PHP Parse error:  syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /vagrant/libs/doctrine2/tests/Doctrine/Tests/ORM/UnitOfWorkTest.php on line 343
PHP Stack trace:
PHP   1. {main}() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/phpunit:47
PHP   3. PHPUnit_TextUI_Command->run() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/TextUI/Command.php:100
PHP   4. PHPUnit_Runner_BaseTestRunner->getTest() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/TextUI/Command.php:123
PHP   5. PHPUnit_Runner_BaseTestRunner->loadSuiteClass() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Runner/BaseTestRunner.php:67
PHP   6. PHPUnit_Runner_StandardTestSuiteLoader->load() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Runner/BaseTestRunner.php:123
PHP   7. PHPUnit_Util_Fileloader::checkAndLoad() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Runner/StandardTestSuiteLoader.php:39
PHP   8. PHPUnit_Util_Fileloader::load() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Util/Fileloader.php:38
Originally created by @tPl0ch on GitHub (Jun 8, 2016). Originally assigned to: @Ocramius on GitHub. PHP 5.4 has reached end of life I don't understand why the travis run for PHP 5.4 is still required. See https://travis-ci.org/doctrine/doctrine2/jobs/135986241 It currently breaks travis builds for new PRs, i.e. the UnitOfWorkTest is using the `Country::class` notation which was introduced in PHP 5.5 (which will actually reach EOL very soon, too). Not sure if making `UnitOfWorkTest` use `get_class()` for now, or just remove PHP 5.4 from the travis build. ``` $ php -v PHP 5.4.40-1~dotdeb+wheezy.1 (cli) (built: Apr 22 2015 06:50:56) Copyright (c) 1997-2014 The PHP Group Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans with Zend OPcache v7.0.3-dev, Copyright (c) 1999-2013, by Zend Technologies $ ./vendor/bin/phpunit tests/Doctrine/Tests/ORM/UnitOfWorkTest.php PHP Parse error: syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /vagrant/libs/doctrine2/tests/Doctrine/Tests/ORM/UnitOfWorkTest.php on line 343 PHP Stack trace: PHP 1. {main}() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/phpunit:0 PHP 2. PHPUnit_TextUI_Command::main() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/phpunit:47 PHP 3. PHPUnit_TextUI_Command->run() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/TextUI/Command.php:100 PHP 4. PHPUnit_Runner_BaseTestRunner->getTest() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/TextUI/Command.php:123 PHP 5. PHPUnit_Runner_BaseTestRunner->loadSuiteClass() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Runner/BaseTestRunner.php:67 PHP 6. PHPUnit_Runner_StandardTestSuiteLoader->load() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Runner/BaseTestRunner.php:123 PHP 7. PHPUnit_Util_Fileloader::checkAndLoad() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Runner/StandardTestSuiteLoader.php:39 PHP 8. PHPUnit_Util_Fileloader::load() /vagrant/libs/doctrine2/vendor/phpunit/phpunit/src/Util/Fileloader.php:38 ```
admin added the Improvement label 2026-01-22 14:59:37 +01:00
admin closed this issue 2026-01-22 14:59:38 +01:00
admin commented 2026-01-22 14:59:39 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Jun 8, 2016):

I'd say "go on and make a PR". Dropping 5.4 was indeed gonna happen :-)

@Ocramius commented on GitHub (Jun 8, 2016): I'd say "go on and make a PR". Dropping 5.4 was indeed gonna happen :-)
admin commented 2026-01-22 14:59:41 +01:00
Author
Owner
Copy Link

@Ocramius commented on GitHub (Jun 8, 2016):

Handled via #5863

@Ocramius commented on GitHub (Jun 8, 2016): Handled via #5863
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Improvement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#5145
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?