mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-5: Remove unsigned/fixed #5
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Sep 14, 2009).
Jira issue originally created by user romanb:
Changeset 6348 introduced unsigned/fixed properties for column metadata. Unsigned is completely unportable and fixed is unnecessary (we could simply introduce a fixed string type for this).
These 2 properties need to be removed.
@doctrinebot commented on GitHub (Sep 14, 2009):
Comment created by romanb:
[Comment from guilhermeblanco:]
Ok, perfect!
We could easily drop it. But I'd also suggest that we simplify the SchemaManagers?, since it does a lot of weird things (looks like an imported piece of 1.X code) to return a better handled (and more useful) information for us.
Also... we should even consider moving that piece of code to ORM, since it's an ORM specific information (converts DBAL datatypes to ORM datatypes).
@doctrinebot commented on GitHub (Sep 19, 2009):
Issue was closed with resolution "Fixed"
@doctrinebot commented on GitHub (Feb 28, 2011):
Comment created by rsauvat_inet:
Sorry to comment on an old bug but I have a problem. I understand why you want to remove the unsigned property and you proposed to remove the fixed property and implement a fixedstring type. But the problem is you removed the fixed property without implementing the new type so with Doctrine 2 it is not possible to create CHAR columns instead of VARCHAR which is different performance and storage wise in the database.
@doctrinebot commented on GitHub (Feb 28, 2011):
Comment created by @beberlei:
You can, use the columnDefinition http://www.doctrine-project.org/docs/orm/2.0/en/reference/annotations-reference.html#annref-column or just define your own type.