mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3993: [GH-1552] Collection cache key is built differently on read than on write #4874
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Nov 11, 2015).
Originally assigned to: @guilhermeblanco on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of guiwoda:
Url: https://github.com/doctrine/doctrine2/pull/1552
Message:
This one's a quick bugfix that would be better if we could refactor key building logic inside the
\Doctrine\ORM\Cacheimplementations, but that would be a (albeit small) BC break in its current API.I intentionally named the refactored protected method exactly as its named in
\Doctrine\ORM\DefaultCache.Testing this proved harder than what it's worth. I'm actually patching this in userland, and you'll find the bug and correction pretty obvious if you look at both the modified class and
\Doctrine\ORM\DefaultCache, so I hope we can merge this one and maybe work on a full test suite for all of the Persister strategies.Cheers!