mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-3956: Incorrect type-hinting in EntityRepository #4836
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Oct 20, 2015).
Originally assigned to: @Majkl578 on GitHub.
Jira issue originally created by user mindplay:
In the current ORM release, the $em argument in the constructor of EntityRepository isn't type-hinted - this makes our dependency injection container cry.
In the head of master, it's now type-hinted as EntityManagerInterface, so clearly somebody noticed this is an issue (?)
However, it's still inconsistent with the php-doc annotation, which says the argument type is EntityRepository.
Which one is correct?
@Majkl578 commented on GitHub (Aug 30, 2017):
This was fixed by #6599.