DDC-3894: [GH-1503] Move dispatchPostFlushEvent method below #4765

Closed
opened 2026-01-22 14:48:54 +01:00 by admin · 4 comments
Owner

Originally created by @doctrinebot on GitHub (Sep 4, 2015).

Originally assigned to: @Ocramius on GitHub.

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of aivus:

Url: https://github.com/doctrine/doctrine2/pull/1503

Message:

This related with b6c3fc5b1a

This PR fix possible issues with flush call inside postFlush event.

I fully understand this is _not good idea_ to call flush inside postFlush event, but this change makes this unsafe code to more safe.

Current implementation has some issues: collections collectionUpdates, collectionDeletions not cleared after works and stay dirty in the second flush.

Originally created by @doctrinebot on GitHub (Sep 4, 2015). Originally assigned to: @Ocramius on GitHub. Jira issue originally created by user @doctrinebot: This issue is created automatically through a Github pull request on behalf of aivus: Url: https://github.com/doctrine/doctrine2/pull/1503 Message: This related with https://github.com/doctrine/doctrine2/commit/b6c3fc5b1ab8f97ba3a47b5a667ef8986c48059e This PR fix possible issues with `flush` call inside `postFlush` event. I fully understand this is **_not good idea**_ to call `flush` inside `postFlush` event, but this change makes this unsafe code to more safe. Current implementation has some issues: collections `collectionUpdates`, `collectionDeletions` not cleared after works and stay `dirty` in the second `flush`.
admin added the Improvement label 2026-01-22 14:48:54 +01:00
admin closed this issue 2026-01-22 14:48:55 +01:00
Author
Owner

@doctrinebot commented on GitHub (Sep 7, 2015):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1503] was closed:
https://github.com/doctrine/doctrine2/pull/1503

@doctrinebot commented on GitHub (Sep 7, 2015): Comment created by @doctrinebot: A related Github Pull-Request [GH-1503] was closed: https://github.com/doctrine/doctrine2/pull/1503
Author
Owner

@doctrinebot commented on GitHub (Sep 7, 2015):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1503] was assigned:
https://github.com/doctrine/doctrine2/pull/1503

@doctrinebot commented on GitHub (Sep 7, 2015): Comment created by @doctrinebot: A related Github Pull-Request [GH-1503] was assigned: https://github.com/doctrine/doctrine2/pull/1503
Author
Owner

@doctrinebot commented on GitHub (Sep 7, 2015):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1503] was labeled:
https://github.com/doctrine/doctrine2/pull/1503

@doctrinebot commented on GitHub (Sep 7, 2015): Comment created by @doctrinebot: A related Github Pull-Request [GH-1503] was labeled: https://github.com/doctrine/doctrine2/pull/1503
Author
Owner

@doctrinebot commented on GitHub (Sep 7, 2015):

Issue was closed with resolution "Invalid"

@doctrinebot commented on GitHub (Sep 7, 2015): Issue was closed with resolution "Invalid"
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#4765