DDC-3843: indexBy collection loses index key after calling a ->matching(criteria) on it #4709

New Issue

admin · 2026-01-22T14:48:04+01:00

admin commented

2026-01-22 14:48:04 +01:00

Originally created by @doctrinebot on GitHub (Jul 22, 2015).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user bitonda:

When I retrieve a filtered collection of entities which has indexBy attribute it loses index keys in the result. Before calling matching() method i tried to call toArray() and It solved the problem, I don't know if it is a bug .

class Entity {
/****
     * @var ArrayCollection
     * @ORM\OneToMany(targetEntity="Entity\Arcansel\BasketItem",mappedBy="userSession",indexBy="id",cascade={"persist","remove","merge"})
     */
    protected $basketItems;


// Some comments here
public function getBasketItems()
    {
        $date = DateTime::newDateTimeUniversal();
        $criteria = Criteria::create()->where(Criteria::expr()->gt("addTime",$date));
        // next line of code prevents returned collection to lose indexBy keys
        $a = $this->basketItems->toArray();
        return $this->basketItems->matching($criteria);
    }
}

Originally created by @doctrinebot on GitHub (Jul 22, 2015). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user bitonda: When I retrieve a filtered collection of entities which has indexBy attribute it loses index keys in the result. Before calling matching() method i tried to call toArray() and It solved the problem, I don't know if it is a bug . ``` class Entity { /**** * @var ArrayCollection * @ORM\OneToMany(targetEntity="Entity\Arcansel\BasketItem",mappedBy="userSession",indexBy="id",cascade={"persist","remove","merge"}) */ protected $basketItems; // Some comments here public function getBasketItems() { $date = DateTime::newDateTimeUniversal(); $criteria = Criteria::create()->where(Criteria::expr()->gt("addTime",$date)); // next line of code prevents returned collection to lose indexBy keys $a = $this->basketItems->toArray(); return $this->basketItems->matching($criteria); } } ```

admin added the Bug label 2026-01-22 14:48:04 +01:00

admin commented

2026-01-22 14:48:05 +01:00

@vlastv commented on GitHub (Dec 8, 2015):

+1

@vlastv commented on GitHub (Dec 8, 2015): +1

admin commented

2026-01-22 14:48:05 +01:00

@Ocramius commented on GitHub (Dec 9, 2015):

Related: #5539

@Ocramius commented on GitHub (Dec 9, 2015): Related: #5539

admin commented

2026-01-22 14:48:06 +01:00

@ureimers commented on GitHub (Mar 15, 2016):

Also having the same issue.

Calling toArray() solves the problem because the collection becomes initialized (loaded entirely from the DB). If a collection is initialized, matching() doesn't trigger a DB-Query but acts directly on the already loaded collection.

But calling toArray() as a workaround before calling matching() effectively kills the benefit of using matching() in the first place.

@ureimers commented on GitHub (Mar 15, 2016): Also having the same issue. Calling `toArray()` solves the problem because the collection becomes initialized (loaded entirely from the DB). If a collection is initialized, `matching()` doesn't trigger a DB-Query but acts directly on the already loaded collection. But calling `toArray()` as a workaround before calling `matching()` effectively kills the benefit of using `matching()` in the first place.

admin commented

2026-01-22 14:48:06 +01:00

@chmielot commented on GitHub (Apr 15, 2016):

+1

@chmielot commented on GitHub (Apr 15, 2016): +1

admin commented

2026-01-22 14:48:07 +01:00

@maresja1 commented on GitHub (May 20, 2016):

+1

@maresja1 commented on GitHub (May 20, 2016): +1

admin commented

2026-01-22 14:48:07 +01:00

@ericnilo commented on GitHub (Jun 1, 2016):

+1

@ericnilo commented on GitHub (Jun 1, 2016): +1

admin commented

2026-01-22 14:48:07 +01:00

@internalsystemerror commented on GitHub (Feb 22, 2017):

+1

@internalsystemerror commented on GitHub (Feb 22, 2017): +1

admin commented

2026-01-22 14:48:08 +01:00

@janwebdev commented on GitHub (Apr 3, 2017):

+1

@janwebdev commented on GitHub (Apr 3, 2017): +1

admin commented

2026-01-22 14:48:08 +01:00

@pavliktomas commented on GitHub (Jan 18, 2018):

+1

@pavliktomas commented on GitHub (Jan 18, 2018): +1

admin commented

2026-01-22 14:48:08 +01:00

@pesu commented on GitHub (Jun 23, 2018):

+1

@pesu commented on GitHub (Jun 23, 2018): +1

admin commented

2026-01-22 14:48:08 +01:00

@beberlei commented on GitHub (Feb 16, 2020):

The problem here is that the line in PersistentCollection#matching must be changed to iterate over the results and build the indexed by map afterwards if indexBy isset:

new ArrayCollection($persister->loadCriteria($criteria));

@beberlei commented on GitHub (Feb 16, 2020): The problem here is that the line in `PersistentCollection#matching` must be changed to iterate over the results and build the indexed by map afterwards if indexBy isset: ```php new ArrayCollection($persister->loadCriteria($criteria)); ```

admin commented

2026-01-22 14:48:09 +01:00

@rela589n commented on GitHub (May 29, 2024):

Hi @greg0ire , if you have some free time, could you look at this?

@rela589n commented on GitHub (May 29, 2024): Hi @greg0ire , if you have some free time, could you look at this?

admin commented

2026-01-22 14:48:09 +01:00

@greg0ire commented on GitHub (May 29, 2024):

I have other priorities, sorry.

@greg0ire commented on GitHub (May 29, 2024): I have other priorities, sorry.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#4709