mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3841: [GH-1470] [CI] Added dev requirement for "doctrine/coding-standard" #4703
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Jul 20, 2015).
Originally assigned to: @lcobucci on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of phansys:
Url: https://github.com/doctrine/doctrine2/pull/1470
Message:
doctrine/coding-standard.before_scriptlifecycle.@doctrinebot commented on GitHub (Jul 20, 2015):
@doctrinebot commented on GitHub (Jul 20, 2015):
Comment created by phansys:
Take this as a probe of the current status of the Doctrine's CS. IMO, we should decide how to proceed in order to get a clean codebase, and I think we should apply some tool like PHP-CS-Fixer or update PHP_CodeSniffer to 2.0 in order to achieve the same feature.
Ping @Ocramius.
@doctrinebot commented on GitHub (Jul 21, 2015):
Comment created by @ocramius:
[~phansys] I already replied on the PR: needs CS changes before merging, and other PRs take priority first.
@doctrinebot commented on GitHub (Jul 21, 2015):
Comment created by phansys:
[~Ocramius], auto CS fixes aren't available with PHP_CodeSniffer at 1.x version (they are in yet unreleased 2.x); that is why I created this PR https://github.com/doctrine/doctrine2/pull/1460 using PHP-CS-fixer, while I've also added a rule for Doctrine's logical NOT CS: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1303.
IMO, at some point we should use any of these tools to ensure all the CS rules are respected.
@Majkl578 commented on GitHub (Dec 8, 2017):
Done in
2be1b7d0b8.